Bug 50739

Summary: [GTK] Add hasSpellingMarker support to the DRT
Product: WebKit Reporter: Alejandro G. Castro <alex>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on: 50738    
Bug Blocks:    
Attachments:
Description Flags
Proposed patch mrobinson: review+

Alejandro G. Castro
Reported 2010-12-09 01:56:33 PST
We need to add support to hasSpellingMarker in order to make the spelling tests to pass.
Attachments
Proposed patch (7.77 KB, patch)
2010-12-09 02:56 PST, Alejandro G. Castro 		mrobinson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alejandro G. Castro
Comment 1 2010-12-09 02:56:07 PST
Created attachment 76031 [details] Proposed patch
Martin Robinson
Comment 2 2010-12-09 03:07:06 PST
Comment on attachment 76031 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=76031&action=review > WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:418 > + return coreFrame->editor()->selectionStartHasSpellingMarkerFor(from, length); Maybe just core(frame)->... here before landing. > WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h:74 > + static bool webkitWebFrameSelectionHasSpellingMarker(WebKitWebFrame *frame, gint from, gint length); Please remove the variable name before landing.
Alejandro G. Castro
Comment 3 2010-12-10 10:20:58 PST
Landed http://trac.webkit.org/changeset/73740
Note You need to log in before you can comment on or make changes to this bug.