Summary: | [GTK] Add hasSpellingMarker support to the DRT | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alejandro G. Castro <alex> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | eric, mrobinson | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Bug Depends on: | 50738 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Alejandro G. Castro
2010-12-09 01:56:33 PST
Created attachment 76031 [details]
Proposed patch
Comment on attachment 76031 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=76031&action=review > WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:418 > + return coreFrame->editor()->selectionStartHasSpellingMarkerFor(from, length); Maybe just core(frame)->... here before landing. > WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h:74 > + static bool webkitWebFrameSelectionHasSpellingMarker(WebKitWebFrame *frame, gint from, gint length); Please remove the variable name before landing. |