| Summary: | REGRESSION (r72052): “Search” placeholder in MobileMe mail is positioned too high | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adele Peterson <adele> | ||||
| Component: | Forms | Assignee: | Adele Peterson <adele> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, eric, mitz, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Adele Peterson
2010-12-08 17:02:10 PST
Created attachment 75990 [details]
patch
Comment on attachment 75990 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=75990&action=review > WebCore/rendering/RenderTextControlSingleLine.cpp:1132 > + return innerRenderer->y(); I hope this isn't too simplistic. Comment on attachment 75990 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=75990&action=review >> WebCore/rendering/RenderTextControlSingleLine.cpp:1132 >> + return innerRenderer->y(); > > I hope this isn't too simplistic. The best way to answer that question is add more test cases. I'm going to add a few more tests, with at least one that covers transformed controls. (In reply to comment #3) > (From update of attachment 75990 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=75990&action=review > > >> WebCore/rendering/RenderTextControlSingleLine.cpp:1132 > >> + return innerRenderer->y(); > > > > I hope this isn't too simplistic. > > The best way to answer that question is add more test cases. Committed revision 73572. http://trac.webkit.org/changeset/73572 might have broken GTK Linux 32-bit Release |