Bug 50717

Summary:

Add getter and setters for acceleratesRendering flag on layers

Product:

WebKit

Reporter:

Matthew Delaney <mdelaney7>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, charles-webkit, eric, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.6

Bug Depends on:

Bug Blocks:

50591

Attachments:

Description	Flags
Patch	none
Patch	simon.fraser: review+

Description Matthew Delaney 2010-12-08 14:18:59 PST

Add getter and setters for acceleratesRendering flag on layers.

Comment 1 Matthew Delaney 2010-12-08 14:37:55 PST

Created attachment 75968 [details]
Patch

Comment 2 Simon Fraser (smfr) 2010-12-08 14:43:05 PST

Comment on attachment 75968 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=75968&action=review

> WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm:95
> +- (void)setAcceleratesDrawing:(BOOL)flag;
> +- (BOOL)acceleratesDrawing;

This needs the platform #if guards.

Comment 3 Matthew Delaney 2010-12-08 14:50:15 PST

Created attachment 75973 [details]
Patch

Comment 4 Eric Seidel (no email) 2010-12-08 15:59:34 PST

Attachment 75973 [details] did not build on mac:
Build output: http://queues.webkit.org/results/6858091

Comment 5 Matthew Delaney 2010-12-08 17:55:18 PST

Committed r73578: <http://trac.webkit.org/changeset/73578>

Comment 6 Matthew Delaney 2010-12-08 17:56:00 PST

Manually fixed the build issue for SL on my local SL machine - just an unused param error.

Comment 7 WebKit Review Bot 2010-12-09 02:22:41 PST

http://trac.webkit.org/changeset/73578 might have broken GTK Linux 32-bit Release