Bug 50717 - Add getter and setters for acceleratesRendering flag on layers
Summary: Add getter and setters for acceleratesRendering flag on layers
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.6
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 50591
  Show dependency treegraph
Reported: 2010-12-08 14:18 PST by Matthew Delaney
Modified: 2010-12-09 02:22 PST (History)
4 users (show)

See Also:

Patch (6.48 KB, patch)
2010-12-08 14:37 PST, Matthew Delaney
no flags Details | Formatted Diff | Diff
Patch (6.59 KB, patch)
2010-12-08 14:50 PST, Matthew Delaney
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Delaney 2010-12-08 14:18:59 PST
Add getter and setters for acceleratesRendering flag on layers.
Comment 1 Matthew Delaney 2010-12-08 14:37:55 PST
Created attachment 75968 [details]
Comment 2 Simon Fraser (smfr) 2010-12-08 14:43:05 PST
Comment on attachment 75968 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=75968&action=review

> WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm:95
> +- (void)setAcceleratesDrawing:(BOOL)flag;
> +- (BOOL)acceleratesDrawing;

This needs the platform #if guards.
Comment 3 Matthew Delaney 2010-12-08 14:50:15 PST
Created attachment 75973 [details]
Comment 4 Eric Seidel (no email) 2010-12-08 15:59:34 PST
Attachment 75973 [details] did not build on mac:
Build output: http://queues.webkit.org/results/6858091
Comment 5 Matthew Delaney 2010-12-08 17:55:18 PST
Committed r73578: <http://trac.webkit.org/changeset/73578>
Comment 6 Matthew Delaney 2010-12-08 17:56:00 PST
Manually fixed the build issue for SL on my local SL machine - just an unused param error.
Comment 7 WebKit Review Bot 2010-12-09 02:22:41 PST
http://trac.webkit.org/changeset/73578 might have broken GTK Linux 32-bit Release