Summary: | [Qt] Move to BUILDING_WEBKIT flag as used by other ports (and away from BUILD_WEBKIT) | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Siddharth Mathur <s.mathur> | ||||
Component: | WebKit Qt | Assignee: | Siddharth Mathur <s.mathur> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Minor | CC: | abarth, ademar, commit-queue, eric, hausmann, webkit.review.bot | ||||
Priority: | P3 | Keywords: | Qt | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Siddharth Mathur
2010-12-08 13:43:41 PST
Created attachment 76003 [details]
Patch
Comment on attachment 76003 [details]
Patch
LGTM, r+.
Next time please add "[Qt] " as a prefix of the title of the ChangeLog/bug if the change is specific to the Qt port.
The commit-queue encountered the following flaky tests while processing attachment 76003 [details]: http/tests/appcache/update-cache.html Please file bugs against the tests. These tests were authored by ap@webkit.org. The commit-queue is continuing to process your patch. Comment on attachment 76003 [details] Patch Clearing flags on attachment: 76003 Committed r73602: <http://trac.webkit.org/changeset/73602> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/73602 might have broken GTK Linux 64-bit Debug The following tests are not passing: editing/selection/extend-by-character-002.html |