Bug 50713

Summary: [Qt] Move to BUILDING_WEBKIT flag as used by other ports (and away from BUILD_WEBKIT)
Product: WebKit Reporter: Siddharth Mathur <s.mathur>
Component: WebKit QtAssignee: Siddharth Mathur <s.mathur>
Status: RESOLVED FIXED    
Severity: Minor CC: abarth, ademar, commit-queue, eric, hausmann, webkit.review.bot
Priority: P3 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Siddharth Mathur
Reported 2010-12-08 13:43:41 PST
All Webkit ports except Qt use BUILDING_WEBKIT to signal that Webkit's shared library/DLL is being compiled. We should preferably stick to this convention and not use our own BUILD_WEBKIT
Attachments
Patch (1.92 KB, patch)
2010-12-08 19:21 PST, Siddharth Mathur 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Siddharth Mathur
Comment 1 2010-12-08 19:21:42 PST
Created attachment 76003 [details] Patch
Laszlo Gombos
Comment 2 2010-12-08 23:54:16 PST
Comment on attachment 76003 [details] Patch LGTM, r+. Next time please add "[Qt] " as a prefix of the title of the ChangeLog/bug if the change is specific to the Qt port.
WebKit Commit Bot
Comment 3 2010-12-09 03:11:23 PST
The commit-queue encountered the following flaky tests while processing attachment 76003 [details]: http/tests/appcache/update-cache.html Please file bugs against the tests. These tests were authored by ap@webkit.org. The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 4 2010-12-09 03:13:09 PST
Comment on attachment 76003 [details] Patch Clearing flags on attachment: 76003 Committed r73602: <http://trac.webkit.org/changeset/73602>
WebKit Commit Bot
Comment 5 2010-12-09 03:13:14 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 6 2010-12-09 04:37:33 PST
http://trac.webkit.org/changeset/73602 might have broken GTK Linux 64-bit Debug The following tests are not passing: editing/selection/extend-by-character-002.html
Note You need to log in before you can comment on or make changes to this bug.