Summary: | [chromium] remove --use-drt and add --use-test-shell | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tony Chang <tony> | ||||||
Component: | New Bugs | Assignee: | Tony Chang <tony> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, dpranke, eric, ojan, tkent | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Tony Chang
2010-12-08 11:26:49 PST
Created attachment 75934 [details]
Patch
Patch LGTM as well ... Do we still use the ChromiumDriver code on Windows and Linux and only use the WebKitDriver code on the Mac? I wonder if that has something to do with the flakiness I'm seeing. (In reply to comment #2) > Do we still use the ChromiumDriver code on Windows and Linux and only use the WebKitDriver code on the Mac? I wonder if that has something to do with the flakiness I'm seeing. Yes, I think that's right. I swapped to ChromiumDriver on Linux because of random test timeouts, so it might be related. We should probably just switch to ChromiumDriver until we can figure out why WebKitDriver is flaky for Chromium DRT. (In reply to comment #3) > (In reply to comment #2) > > Do we still use the ChromiumDriver code on Windows and Linux and only use the WebKitDriver code on the Mac? I wonder if that has something to do with the flakiness I'm seeing. > > Yes, I think that's right. I swapped to ChromiumDriver on Linux because of random test timeouts, so it might be related. We should probably just switch to ChromiumDriver until we can figure out why WebKitDriver is flaky for Chromium DRT. Okay, I'll test that locally and report back. Created attachment 76219 [details]
Patch
I found a few more uses of use_drt outside of the layout_tests dir (e.g., the ews bots) so I updated the patch. Committed r73748: <http://trac.webkit.org/changeset/73748> |