Bug 50688

Summary: check-webkit-style failed with a false-positive error
Product: WebKit Reporter: Cosmin Truta <ctruta>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: All   

Description Cosmin Truta 2010-12-08 07:33:07 PST
check-webkit-style failed, indicating an error that is a false positive. My patch cannot go further because of that.


Quote from bug 50310:


Attachment 75857 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/update-webkit']" exit_code: 2
Updating OpenSource
Incomplete data: Delta source ended unexpectedly at /usr/lib/git-core/git-svn line 5061

Died at WebKitTools/Scripts/update-webkit line 132.

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 1 Eric Seidel (no email) 2010-12-08 13:21:38 PST
Yes, we're working on fixing the machine.  Thank you for the bug!
Comment 2 Adam Barth 2010-12-08 19:16:18 PST
I'm very sorry about these issues.  As you can tell, we're not expert sysadmins...
Comment 3 Cosmin Truta 2010-12-08 20:31:38 PST
(In reply to comment #2)
> I'm very sorry about these issues.  As you can tell, we're not expert sysadmins...

No problemo -- but may I have some help to land the patch 75857 from bug 50310, which seems to be stuck because of this?
Comment 4 Adam Barth 2010-12-08 20:39:05 PST
Not really.  The bubbles are just advisory.
Comment 5 Cosmin Truta 2010-12-08 20:48:57 PST
(In reply to comment #4)
> Not really.  The bubbles are just advisory.

Aha, good to know. And thanks for r+/cq+. Now I won't have to worry about that red bubble which might scare off potential reviewers ;-)
Comment 6 David Levin 2010-12-14 22:18:30 PST
The issue as stated is fixed or invalid. (check-webkit-style wasn't giving a false positive really. It was the bot which had issues.)

Anyway, there is no bug to fix anyone, so I'm resolving.