Bug 50685

Summary:

[Qt] Support OrientationChange event

Product:

WebKit

Reporter:

qi <qi.2.zhang>

Component:

New Bugs

Assignee:

qi <qi.2.zhang>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ademar, commit-queue, cshu, diegohcg, kling, laszlo.gombos, suresh.voruganti

Priority:

Keywords:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
patch	none
patch for qtwebkit2.1	none

Reported 2010-12-08 07:03:18 PST

We need support "OrientationChange" event in Qt. https://qtrequirements.europe.nokia.com/browse/BR-5525

Attachments
patch (3.93 KB, patch) 2010-12-08 07:26 PST, qi	no flags	Details Formatted Diff Diff
patch for qtwebkit2.1 (4.33 KB, application/octet-stream) 2010-12-13 07:30 PST, Chang Shu	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Comment 1 2010-12-08 07:26:47 PST

Created attachment 75902 [details] patch Get the OrientationChange event from qtmobility, then send to webkit.

Kenneth Rohde Christiansen

Comment 2 2010-12-08 07:34:48 PST

Comment on attachment 75902 [details] patch I wonder how this affects the media feature -webkit-orientation. like if I do @media screen and (-webkit-orientation: landscape) { body { background-color: green; } }

Comment 3 2010-12-08 07:44:53 PST

I am not really sure what the "-webkit-orientation" is. But I think my code will not affect this feature, because this code just listen for sensor and send event to webkit. The behavior depends on webkit, if the webkit want to force the orientation in this case, they can ignore this event.

WebKit Commit Bot

Comment 4 2010-12-08 19:11:06 PST

Comment on attachment 75902 [details] patch Clearing flags on attachment: 75902 Committed r73584: <http://trac.webkit.org/changeset/73584>

WebKit Commit Bot

Comment 5 2010-12-08 19:11:19 PST

All reviewed patches have been landed. Closing bug.

Chang Shu

Comment 6 2010-12-13 07:30:17 PST

Created attachment 76384 [details] patch for qtwebkit2.1 Create patch for qtwebkit2.1

Suresh Voruganti

Comment 7 2010-12-13 13:58:31 PST

Fix required for Qtwebkit 2.1/2.2. Developer has also attached the back ported version of the patch for Qtwebkit 2.1/2.2

Ademar Reis

Comment 8 2010-12-20 13:05:53 PST

Revision r73584 cherry-picked into qtwebkit-2.2 with commit f339029 <http://gitorious.org/webkit/qtwebkit/commit/f339029>

Diego Gonzalez

Comment 9 2011-02-23 10:45:17 PST

*** Bug 36829 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.