Summary: | [Qt] Support OrientationChange event | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | qi <qi.2.zhang> | ||||||
Component: | New Bugs | Assignee: | qi <qi.2.zhang> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ademar, commit-queue, cshu, diegohcg, kling, laszlo.gombos, suresh.voruganti | ||||||
Priority: | P2 | Keywords: | Qt | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Attachments: |
|
Description
qi
2010-12-08 07:03:18 PST
Created attachment 75902 [details]
patch
Get the OrientationChange event from qtmobility, then send to webkit.
Comment on attachment 75902 [details]
patch
I wonder how this affects the media feature -webkit-orientation.
like if I do
@media screen and (-webkit-orientation: landscape) {
body { background-color: green; }
}
I am not really sure what the "-webkit-orientation" is. But I think my code will not affect this feature, because this code just listen for sensor and send event to webkit. The behavior depends on webkit, if the webkit want to force the orientation in this case, they can ignore this event. Comment on attachment 75902 [details] patch Clearing flags on attachment: 75902 Committed r73584: <http://trac.webkit.org/changeset/73584> All reviewed patches have been landed. Closing bug. Created attachment 76384 [details]
patch for qtwebkit2.1
Create patch for qtwebkit2.1
Fix required for Qtwebkit 2.1/2.2. Developer has also attached the back ported version of the patch for Qtwebkit 2.1/2.2 Revision r73584 cherry-picked into qtwebkit-2.2 with commit f339029 <http://gitorious.org/webkit/qtwebkit/commit/f339029> |