| Summary: | Default styling rules for the figure and figcaption elements | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Peter Beverloo <peter> | ||||||
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, darin, mathias | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | OS X 10.5 | ||||||||
| URL: | http://www.whatwg.org/specs/web-apps/current-work/multipage/grouping-content.html#the-figure-element | ||||||||
| Attachments: |
|
||||||||
|
Description
Peter Beverloo
2010-12-08 06:34:51 PST
Created attachment 75896 [details]
Patch
Comment on attachment 75896 [details]
Patch
Looks reasonable to me.
Comment on attachment 75896 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=75896&action=review Also it looks like the test cases don't test the styles. > WebCore/css/html.css:90 > margin: 1__qem 40px 1em 40px I don't think this rule is right for figure. The 1__qem invokes a quirk in quirks mode that is needed for historical reasons for blockquote, but there is no need to have the same quirk for figure. Created attachment 76035 [details]
Revised patch
Thank you for the review. I have addressed your points, figure now has its own definition in html.css and I've added testing of the default styles.
I'd appreciate it if you could check whether my approach with the "emSize" variable in the tests is correct.
Comment on attachment 76035 [details]
Revised patch
r=me
Comment on attachment 76035 [details] Revised patch Clearing flags on attachment: 76035 Committed r73613: <http://trac.webkit.org/changeset/73613> All reviewed patches have been landed. Closing bug. |