Bug 50684

Summary: Default styling rules for the figure and figcaption elements
Product: WebKit Reporter: Peter Beverloo <peter>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, mathias
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
URL: http://www.whatwg.org/specs/web-apps/current-work/multipage/grouping-content.html#the-figure-element
Attachments:
Description Flags
Patch
mjs: review-, mjs: commit-queue-
Revised patch none

Peter Beverloo
Reported 2010-12-08 06:34:51 PST
This patch adds default styling rules for the <figure> and <figcaption> elements to html.css. The elements themselfes were added by Adam Barth during work on the tree-builder.
Attachments
Patch (8.92 KB, patch)
2010-12-08 06:35 PST, Peter Beverloo 		mjs: review-
mjs: commit-queue-
DetailsFormatted DiffDiff
Revised patch (10.16 KB, patch)
2010-12-09 03:04 PST, Peter Beverloo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Peter Beverloo
Comment 1 2010-12-08 06:35:38 PST
Created attachment 75896 [details] Patch
Adam Barth
Comment 2 2010-12-09 01:09:06 PST
Comment on attachment 75896 [details] Patch Looks reasonable to me.
Maciej Stachowiak
Comment 3 2010-12-09 01:47:46 PST
Comment on attachment 75896 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=75896&action=review Also it looks like the test cases don't test the styles. > WebCore/css/html.css:90 > margin: 1__qem 40px 1em 40px I don't think this rule is right for figure. The 1__qem invokes a quirk in quirks mode that is needed for historical reasons for blockquote, but there is no need to have the same quirk for figure.
Peter Beverloo
Comment 4 2010-12-09 03:04:53 PST
Created attachment 76035 [details] Revised patch Thank you for the review. I have addressed your points, figure now has its own definition in html.css and I've added testing of the default styles. I'd appreciate it if you could check whether my approach with the "emSize" variable in the tests is correct.
Maciej Stachowiak
Comment 5 2010-12-09 08:15:36 PST
Comment on attachment 76035 [details] Revised patch r=me
WebKit Commit Bot
Comment 6 2010-12-09 08:41:07 PST
Comment on attachment 76035 [details] Revised patch Clearing flags on attachment: 76035 Committed r73613: <http://trac.webkit.org/changeset/73613>
WebKit Commit Bot
Comment 7 2010-12-09 08:41:13 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.