Bug 50676

Summary: [GTK] Layering violation in ContextMenuGtk.cpp
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bweinstein, sullivan
Priority: P3 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on:    
Bug Blocks: 50586    
Attachments:
Description Flags
Patch for this issue sullivan: review+

Martin Robinson
Reported 2010-12-08 03:24:29 PST
ContextMenuGtk shouldn't know about ContextMenuController. This is a companion fix to http://trac.webkit.org/changeset/73469 .
Attachments
Patch for this issue (6.36 KB, patch)
2010-12-08 03:30 PST, Martin Robinson 		sullivan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2010-12-08 03:30:30 PST
Created attachment 75884 [details] Patch for this issue
John Sullivan
Comment 2 2010-12-08 05:52:43 PST
Comment on attachment 75884 [details] Patch for this issue View in context: https://bugs.webkit.org/attachment.cgi?id=75884&action=review > WebKit/gtk/webkit/webkitwebview.cpp:268 > +static void popupMenuItemActivated(GtkMenuItem* item, ContextMenuController* controller) To keep the terminology consistent, I suggest using "contextMenu" rather than "popupMenu" in the name of this function.
Martin Robinson
Comment 3 2010-12-08 11:17:45 PST
Committed r73534: <http://trac.webkit.org/changeset/73534>
Note You need to log in before you can comment on or make changes to this bug.