Bug 50665

Summary: WebMenuTarget implemented in both WebKit and WebKit2
Product: WebKit Reporter: Brian Weinstein <bweinstein>
Component: WebKit Misc.Assignee: Brian Weinstein <bweinstein>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, beidson, eric, mrowe, webkit.review.bot
Priority: P2 Keywords: InRadar, PlatformOnly
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: All   
Attachments:
Description Flags
[PATCH] Fix
beidson: review-
[PATCH] WK2 Fix beidson: review+

Brian Weinstein
Reported 2010-12-07 22:02:12 PST
It shouldn't be, it can cause warnings to be logged. <rdar://problem/8742640>
Attachments
[PATCH] Fix (2.49 KB, patch)
2010-12-07 22:07 PST, Brian Weinstein 		beidson: review-
DetailsFormatted DiffDiff
[PATCH] WK2 Fix (2.48 KB, patch)
2010-12-07 22:16 PST, Brian Weinstein 		beidson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brian Weinstein
Comment 1 2010-12-07 22:07:39 PST
Created attachment 75870 [details] [PATCH] Fix
Brian Weinstein
Comment 2 2010-12-07 22:16:44 PST
Created attachment 75871 [details] [PATCH] WK2 Fix This patch renames the class in WebKit2 instead of the one in WebKit.
Brady Eidson
Comment 3 2010-12-08 14:37:07 PST
Lets do just the WK2 one.
Brian Weinstein
Comment 4 2010-12-08 17:03:23 PST
Landed in r73567.
WebKit Review Bot
Comment 5 2010-12-09 00:34:51 PST
http://trac.webkit.org/changeset/73567 might have broken GTK Linux 32-bit Release The following tests are not passing: fast/css/input-search-padding.html fast/css/text-input-with-webkit-border-radius.html fast/forms/box-shadow-override.html fast/forms/control-restrict-line-height.html fast/forms/input-appearance-height.html fast/forms/placeholder-pseudo-style.html fast/forms/placeholder-set-value.html fast/forms/search-cancel-button-style-sharing.html fast/forms/search-placeholder-value-changed.html fast/forms/search-rtl.html fast/forms/search-styled.html fast/forms/search-transformed.html fast/forms/search-vertical-alignment.html fast/forms/search-zoomed.html fast/forms/searchfield-heights.html
Note You need to log in before you can comment on or make changes to this bug.