Bug 50665 - WebMenuTarget implemented in both WebKit and WebKit2
Summary: WebMenuTarget implemented in both WebKit and WebKit2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: Brian Weinstein
URL:
Keywords: InRadar, PlatformOnly
Depends on:
Blocks:
 
Reported: 2010-12-07 22:02 PST by Brian Weinstein
Modified: 2010-12-09 00:34 PST (History)
5 users (show)

See Also:

Attachments
[PATCH] Fix (2.49 KB, patch)
2010-12-07 22:07 PST, Brian Weinstein 		beidson: review-
Details | Formatted Diff | Diff
[PATCH] WK2 Fix (2.48 KB, patch)
2010-12-07 22:16 PST, Brian Weinstein 		beidson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Weinstein 2010-12-07 22:02:12 PST 
It shouldn't be, it can cause warnings to be logged.

<rdar://problem/8742640>
Comment 1 Brian Weinstein 2010-12-07 22:07:39 PST 
Created attachment 75870 [details]
[PATCH] Fix
Comment 2 Brian Weinstein 2010-12-07 22:16:44 PST 
Created attachment 75871 [details]
[PATCH] WK2 Fix

This patch renames the class in WebKit2 instead of the one in WebKit.
Comment 3 Brady Eidson 2010-12-08 14:37:07 PST 
Lets do just the WK2 one.
Comment 4 Brian Weinstein 2010-12-08 17:03:23 PST 
Landed in r73567.
Comment 5 WebKit Review Bot 2010-12-09 00:34:51 PST 
http://trac.webkit.org/changeset/73567 might have broken GTK Linux 32-bit Release
The following tests are not passing:
fast/css/input-search-padding.html
fast/css/text-input-with-webkit-border-radius.html
fast/forms/box-shadow-override.html
fast/forms/control-restrict-line-height.html
fast/forms/input-appearance-height.html
fast/forms/placeholder-pseudo-style.html
fast/forms/placeholder-set-value.html
fast/forms/search-cancel-button-style-sharing.html
fast/forms/search-placeholder-value-changed.html
fast/forms/search-rtl.html
fast/forms/search-styled.html
fast/forms/search-transformed.html
fast/forms/search-vertical-alignment.html
fast/forms/search-zoomed.html
fast/forms/searchfield-heights.html