Summary: | WebKit2: Implement WebChromeClient::exceededDatabaseQuota | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jessie Berlin <jberlin> | ||||||
Component: | WebKit2 | Assignee: | Jessie Berlin <jberlin> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aroben, beidson, jberlin, sam, webkit-ews, webkit.review.bot | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Jessie Berlin
2010-12-07 16:31:47 PST
Created attachment 75853 [details]
Patch
Attachment 75853 [details] did not build on qt: Build output: http://queues.webkit.org/results/6796090 Attachment 75853 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/update-webkit']" exit_code: 2
Updating OpenSource
Incomplete data: Delta source ended unexpectedly at /usr/lib/git-core/git-svn line 5061
Died at WebKitTools/Scripts/update-webkit line 132.
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 75910 [details]
Patch (with Qt build fix and windows version of MiniBrowser build fix)
I ran check-webkit-style locally (for both this and the previous patch) and it reported 0 errors.
Comment on attachment 75910 [details] Patch (with Qt build fix and windows version of MiniBrowser build fix) View in context: https://bugs.webkit.org/attachment.cgi?id=75910&action=review > WebKit2/UIProcess/API/qt/qwkpage.cpp:364 > + 0, /* pageDidScroll */ > + 0 /* exceededDatabaseQuota */ Maybe you should match the existing spacing here? > WebKitTools/WebKitTestRunner/TestController.cpp:139 > + 0, // pageDidScroll > + 0 // exceededDatabaseQuota And here. > WebKitTools/WebKitTestRunner/TestController.cpp:242 > + 0, // pageDidScroll > + 0 // exceededDatabaseQuota And here. (In reply to comment #5) > (From update of attachment 75910 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=75910&action=review > > > WebKit2/UIProcess/API/qt/qwkpage.cpp:364 > > + 0, /* pageDidScroll */ > > + 0 /* exceededDatabaseQuota */ > > Maybe you should match the existing spacing here? > > > WebKitTools/WebKitTestRunner/TestController.cpp:139 > > + 0, // pageDidScroll > > + 0 // exceededDatabaseQuota > > And here. > > > WebKitTools/WebKitTestRunner/TestController.cpp:242 > > + 0, // pageDidScroll > > + 0 // exceededDatabaseQuota > > And here. I originally matched the existing spaces, and then check-webkit-style complained about the rule where there should only be one space before an end-of-line comment. I will change them back to match the existing spaces. Thanks for the review! Comment on attachment 75910 [details] Patch (with Qt build fix and windows version of MiniBrowser build fix) Committed in r73533 http://trac.webkit.org/changeset/73533 |