Summary: | Migrate buildbot.py from xmlrpclib to json | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | William Siegrist <wsiegrist> | ||||||||||
Component: | Tools / Tests | Assignee: | William Siegrist <wsiegrist> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | commit-queue, eric, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
URL: | http://build.webkit.org | ||||||||||||
Attachments: |
|
Description
William Siegrist
2010-12-07 14:38:34 PST
Created attachment 75847 [details]
change buildbot.py to use json instead of xmlrpc
Comment on attachment 75847 [details]
change buildbot.py to use json instead of xmlrpc
Your ChangeLog has tabs. Looks good though. Assuming you actually ran something like failure-reason which would use this.
Created attachment 75848 [details]
fixed tabs in ChangeLog and added python2.5 support with simplejson
Comment on attachment 75848 [details] fixed tabs in ChangeLog and added python2.5 support with simplejson View in context: https://bugs.webkit.org/attachment.cgi?id=75848&action=review Lgtm. I assume you ran test-webkitpy :) > WebKitTools/ChangeLog:2 > + Reviewed by NOBODY (OOPS!). Normally there is a blank line before this one. Created attachment 75856 [details]
add blank line to ChangeLog, fix mockup of build_dictionary
No, I had not run test-webkitpy, but now I know better. It turns out I needed to update the mockup of build_dictionary to match the new layout of the json data. I also fixed the ChangeLog (again).
Comment on attachment 75856 [details]
add blank line to ChangeLog, fix mockup of build_dictionary
Thanks again!
Attachment 75847 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/update-webkit']" exit_code: 2
Updating OpenSource
Incomplete data: Delta source ended unexpectedly at /usr/lib/git-core/git-svn line 5061
Died at WebKitTools/Scripts/update-webkit line 132.
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 75856 [details] add blank line to ChangeLog, fix mockup of build_dictionary Rejecting patch 75856 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'apply-attachment', '--force-clean', '--non-interactive', 75856]" exit_code: 2 Last 500 characters of output: up to this was: -------------------------- |Index: Scripts/webkitpy/common/net/buildbot.py |=================================================================== |--- Scripts/webkitpy/common/net/buildbot.py (revision 73456) |+++ Scripts/webkitpy/common/net/buildbot.py (working copy) -------------------------- No file to patch. Skipping patch. 4 out of 4 hunks ignored Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/6745109 Created attachment 75903 [details]
recreated patch from the root of the repo so CQ can apply it
Comment on attachment 75903 [details]
recreated patch from the root of the repo so CQ can apply it
Thanks.
The commit-queue encountered the following flaky tests while processing attachment 75903 [details]: inspector/debugger-no-nested-pause.html Please file bugs against the tests. These tests were authored by loislo@chromium.org, podivilov@chromium.org, and yurys@chromium.org. The commit-queue is continuing to process your patch. Comment on attachment 75903 [details] recreated patch from the root of the repo so CQ can apply it Clearing flags on attachment: 75903 Committed r73590: <http://trac.webkit.org/changeset/73590> All reviewed patches have been landed. Closing bug. |