Bug 50640

Summary: Move DOMWindow::setLocation logic into DOMWindow class and out of JavaScript binding
Product: WebKit Reporter: Darin Adler <darin>
Component: DOMAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, ossy, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Darin Adler
Reported 2010-12-07 12:02:03 PST
Move DOMWindow::setLocation logic into DOMWindow class and out of JavaScript binding
Attachments
Patch (10.34 KB, patch)
2010-12-07 12:06 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2010-12-07 12:06:33 PST
Created attachment 75834 [details] Patch
Geoffrey Garen
Comment 2 2010-12-07 12:34:06 PST
Comment on attachment 75834 [details] Patch r=me
WebKit Review Bot
Comment 3 2010-12-07 21:45:39 PST
Attachment 75834 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/update-webkit']" exit_code: 2 Updating OpenSource Incomplete data: Delta source ended unexpectedly at /usr/lib/git-core/git-svn line 5061 Died at WebKitTools/Scripts/update-webkit line 132. If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 4 2010-12-08 08:22:47 PST
Committed r73521: <http://trac.webkit.org/changeset/73521>
Csaba Osztrogonác
Comment 5 2010-12-08 09:59:29 PST
It broke the whole world. :o Could you guys fix it?
Darin Adler
Comment 6 2010-12-08 10:36:33 PST
I am in meetings all day and won’t have time to address this. Can someone roll it out for me? Sorry!
Csaba Osztrogonác
Comment 7 2010-12-08 11:03:45 PST
(In reply to comment #6) > I am in meetings all day and won’t have time to address this. Can someone roll it out for me? > > Sorry! Rolled out by http://trac.webkit.org/changeset/73532
Adam Roben (:aroben)
Comment 8 2010-12-08 11:13:56 PST
I filed bug 50699 about the failures, but I guess we don't need it anymore.
Alexey Proskuryakov
Comment 9 2010-12-08 14:05:09 PST
Comment on attachment 75834 [details] Patch Clearing review+ flag, since this has been rolled out.
Darin Adler
Comment 10 2010-12-09 14:24:49 PST
Committed r73647: <http://trac.webkit.org/changeset/73647>
Ryosuke Niwa
Comment 12 2010-12-09 16:51:46 PST
(In reply to comment #11) > This broke XSS tests: http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r73656%20(24484)/results.html I should have said "it seems like" this change broke XSS tests.
Darin Adler
Comment 13 2010-12-10 16:23:16 PST
(In reply to comment #12) > (In reply to comment #11) > > This broke XSS tests: http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r73656%20(24484)/results.html > > I should have said "it seems like" this change broke XSS tests. Yes, it broke those and the fix was <http://trac.webkit.org/changeset/73660>. Do you think there’s anything still broken after r73660?
Note You need to log in before you can comment on or make changes to this bug.