Bug 50640

Summary: Move DOMWindow::setLocation logic into DOMWindow class and out of JavaScript binding
Product: WebKit Reporter: Darin Adler <darin>
Component: DOMAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, ossy, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Description Darin Adler 2010-12-07 12:02:03 PST 
Move DOMWindow::setLocation logic into DOMWindow class and out of JavaScript binding
Comment 1 Darin Adler 2010-12-07 12:06:33 PST 
Created attachment 75834 [details]
Patch
Comment 2 Geoffrey Garen 2010-12-07 12:34:06 PST 
Comment on attachment 75834 [details]
Patch

r=me
Comment 3 WebKit Review Bot 2010-12-07 21:45:39 PST 
Attachment 75834 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/update-webkit']" exit_code: 2
Updating OpenSource
Incomplete data: Delta source ended unexpectedly at /usr/lib/git-core/git-svn line 5061

Died at WebKitTools/Scripts/update-webkit line 132.


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Darin Adler 2010-12-08 08:22:47 PST 
Committed r73521: <http://trac.webkit.org/changeset/73521>
Comment 5 Csaba Osztrogonác 2010-12-08 09:59:29 PST 
It broke the whole world. :o Could you guys fix it?
Comment 6 Darin Adler 2010-12-08 10:36:33 PST 
I am in meetings all day and won’t have time to address this. Can someone roll it out for me?

Sorry!
Comment 7 Csaba Osztrogonác 2010-12-08 11:03:45 PST 
(In reply to comment #6)
> I am in meetings all day and won’t have time to address this. Can someone roll it out for me?
> 
> Sorry!

Rolled out by http://trac.webkit.org/changeset/73532
Comment 8 Adam Roben (:aroben) 2010-12-08 11:13:56 PST 
I filed bug 50699 about the failures, but I guess we don't need it anymore.
Comment 9 Alexey Proskuryakov 2010-12-08 14:05:09 PST 
Comment on attachment 75834 [details]
Patch

Clearing review+ flag, since this has been rolled out.
Comment 10 Darin Adler 2010-12-09 14:24:49 PST 
Committed r73647: <http://trac.webkit.org/changeset/73647>
Comment 12 Ryosuke Niwa 2010-12-09 16:51:46 PST 
(In reply to comment #11)
> This broke XSS tests: http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r73656%20(24484)/results.html

I should have said "it seems like" this change broke XSS tests.
Comment 13 Darin Adler 2010-12-10 16:23:16 PST 
(In reply to comment #12)
> (In reply to comment #11)
> > This broke XSS tests: http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r73656%20(24484)/results.html
> 
> I should have said "it seems like" this change broke XSS tests.

Yes, it broke those and the fix was <http://trac.webkit.org/changeset/73660>.

Do you think there’s anything still broken after r73660?