Bug 50629

Summary: [GTK] testwebdatasource - unreachable test is broken
Product: WebKit Reporter: Gustavo Noronha (kov) <gustavo>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal Keywords: Gtk
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
proposed patch none

Description Gustavo Noronha (kov) 2010-12-07 07:18:52 PST 
The unreachable test is not testing what it needs to test, because it uses an incorrect condition in the load status notification callback, and unfortunately, after that is fixed the test does not pass. While I figure the problem out, I'll post a patch that fixes the test and disables it.
Comment 1 Gustavo Noronha (kov) 2010-12-07 07:27:29 PST 
Created attachment 75814 [details]
proposed patch
Comment 2 Gustavo Noronha (kov) 2010-12-07 08:14:55 PST 
Comment on attachment 75814 [details]
proposed patch

Xan reviewed the patch in person over my shoulder.
Comment 3 Gustavo Noronha (kov) 2010-12-07 08:15:11 PST 
Landed as 73442.