Bug 50611

Summary: [Chromium] Refactor FontCacheChromiumWin.cpp
Product: WebKit Reporter: Hironori Bono <hbono>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fishd, levin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
A refactoring change none

Description Hironori Bono 2010-12-06 19:20:42 PST 
(Split from WebKit Bug 25770.)
FontCacheChromiumWin.cpp inserts several helper functions between the methods of the WebCore::FontCache class. It is better to move these static functions at the beginning of this file to improve its readability.

(*1) <http://svn.webkit.org/repository/webkit/trunk/WebCore/platform/graphics/chromium/FontCacheChromiumWin.cpp>
Comment 1 Hironori Bono 2010-12-06 19:31:24 PST 
Created attachment 75775 [details]
A refactoring change

Greetings,

This change just moved the static functions and fixed some style issues. (I'm not sure if it is better to use an anonymous namespace for these functions as Chromium code does, though.)

Regards,

Hironori Bono
Comment 2 WebKit Review Bot 2010-12-06 19:35:23 PST 
Attachment 75775 [details] did not pass style-queue:

Failed to run "[u'git', u'reset', u'--hard', u'HEAD']" exit_code: 128
error: Could not write new index file.
fatal: Could not reset index file to revision 'HEAD'.


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2010-12-06 21:05:22 PST 
Comment on attachment 75775 [details]
A refactoring change

Clearing flags on attachment: 75775

Committed r73425: <http://trac.webkit.org/changeset/73425>
Comment 4 WebKit Commit Bot 2010-12-06 21:05:28 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Review Bot 2010-12-07 08:23:30 PST 
Attachment 75775 [details] did not pass style-queue:

Failed to run "[u'git', u'reset', u'--hard', u'refs/remotes/trunk']" exit_code: 128
error: Could not write new index file.
fatal: Could not reset index file to revision 'refs/remotes/trunk'.


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 WebKit Review Bot 2010-12-07 09:25:05 PST 
Attachment 75775 [details] did not pass style-queue:

Failed to run "[u'git', u'reset', u'--hard', u'refs/remotes/trunk']" exit_code: 128
error: Could not write new index file.
fatal: Could not reset index file to revision 'refs/remotes/trunk'.


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 WebKit Review Bot 2010-12-07 10:26:07 PST 
Attachment 75775 [details] did not pass style-queue:

Failed to run "[u'git', u'reset', u'--hard', u'refs/remotes/trunk']" exit_code: 128
error: Could not write new index file.
fatal: Could not reset index file to revision 'refs/remotes/trunk'.


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 WebKit Review Bot 2010-12-07 11:27:03 PST 
Attachment 75775 [details] did not pass style-queue:

Failed to run "[u'git', u'reset', u'--hard', u'refs/remotes/trunk']" exit_code: 128
error: Could not write new index file.
fatal: Could not reset index file to revision 'refs/remotes/trunk'.


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 WebKit Review Bot 2010-12-07 12:28:26 PST 
Attachment 75775 [details] did not pass style-queue:

Failed to run "[u'git', u'reset', u'--hard', u'refs/remotes/trunk']" exit_code: 128
error: Could not write new index file.
fatal: Could not reset index file to revision 'refs/remotes/trunk'.


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 WebKit Review Bot 2010-12-07 21:28:44 PST 
Attachment 75775 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/update-webkit']" exit_code: 2
Updating OpenSource
From git://git.webkit.org/WebKit
   199e777..9473601  master     -> origin/master
Incomplete data: Delta source ended unexpectedly at /usr/lib/git-core/git-svn line 5061

Died at WebKitTools/Scripts/update-webkit line 132.


If any of these errors are false positives, please file a bug against check-webkit-style.