| Summary: | Prototype inheritance test fails due to constructor lookup failure | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Emil A Eklund <eae> | ||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | UNCONFIRMED --- | ||||||||
| Severity: | Normal | CC: | eric, oliver, sam, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Other | ||||||||
| OS: | OS X 10.5 | ||||||||
| Attachments: |
|
||||||||
|
Description
Emil A Eklund
2010-12-06 16:45:29 PST
Created attachment 75752 [details]
Patch
Attachment 75752 [details] did not pass style-queue:
Failed to run "[u'git', u'reset', u'--hard', u'HEAD']" exit_code: 128
error: Could not write new index file.
fatal: Could not reset index file to revision 'HEAD'.
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 75753 [details]
Patch
Attachment 75753 [details] did not pass style-queue:
Failed to run "[u'git', u'reset', u'--hard', u'HEAD']" exit_code: 128
error: Could not write new index file.
fatal: Could not reset index file to revision 'HEAD'.
If any of these errors are false positives, please file a bug against check-webkit-style.
I'm not sure I understand what this change is doing? The test prototype-inheritance-2 is failing as the way it looks up available constructs doesn't work anymore. This change fixes the test by changing the way it does that lookup. At least that's the intention. Oh, so it's currently failing on the bots? When did this regress? Yeah, looks like it's been failing since July 30. I'm confused. It's clearly not ben failing on Mac since that time. Is this a chromium fix? The results you're changing are common results. No, it's for webkit but it might be limited to the gtk and windows ports. Let me check again (on all platforms) and get back to you. |