Summary: | [chromium] Upstream skia/ImageBuffer.cpp routine mulDiv255Ceil() | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | noel gordon <noel.gordon> | ||||||||
Component: | Canvas | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | dglazkov, eric, mdelaney7, senorblanco, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | Windows 7 | ||||||||||
Attachments: |
|
Description
noel gordon
2010-12-05 15:26:07 PST
patch sent http://codereview.appspot.com/3466042 skia rolled into chrome http://src.chromium.org/viewvc/chrome?view=rev&revision=68558 Created attachment 75991 [details]
patch
test_shell is happy before and after this patch Attachment 75991 [details] did not build on chromium: Build output: http://queues.webkit.org/results/6959004 Checked out chromium & webkit ToT, built chromium linux debug/release with the patch fine. Created attachment 76160 [details]
patch try linux ews again
Attachment 76160 [details] did not build on chromium: Build output: http://queues.webkit.org/results/6912020 waiting on EWS and chrome trys to update their chromium DEPS Comment on attachment 76160 [details]
patch try linux ews again
LGTM.
Sadly we currently have no way to cause the EWS to retry other than to upload a new patch. :( Understood, once bug 50984 lands, I will upload again. Created attachment 76488 [details]
patch try linux ews take 2
resending.
The commit-queue encountered the following flaky tests while processing attachment 76488 [details]: inspector/elements-panel-styles.html bug 50987 (author: pfeldman@chromium.org) animations/suspend-resume-animation.html bug 51004 (author: cmarrin@apple.com) The commit-queue is continuing to process your patch. Comment on attachment 76488 [details] patch try linux ews take 2 Clearing flags on attachment: 76488 Committed r73997: <http://trac.webkit.org/changeset/73997> All reviewed patches have been landed. Closing bug. |