[WINCE] Adds a build slave.

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Patrick R. Gansterer]

see patch

[Patrick R. Gansterer]

Created attachment 75614 [details]
Patch

[Eric Seidel (no email)]

_wms should "review" this.

[Csaba Osztrogonác]

Comment on attachment 75614 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=75614&action=review

> WebKitTools/BuildSlaveSupport/build.webkit.org-config/master.cfg:83
>  def appendCustomBuildFlags(step, platform):
> -    if platform in ('gtk', 'wx', 'qt', 'chromium', 'wincairo', 'efl'):
> +    if platform in ('chromium', 'efl', 'gtk', 'qt', 'wincairo', 'wince', 'wx'):
>          step.setCommand(step.command + ['--' + platform])

It would pass --wince option to the build-webkit script.
But I can't find if build-webkit handles wince option.

[Patrick R. Gansterer]

(In reply to comment #3)
> (From update of attachment 75614 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=75614&action=review
> 
> > WebKitTools/BuildSlaveSupport/build.webkit.org-config/master.cfg:83
> >  def appendCustomBuildFlags(step, platform):
> > -    if platform in ('gtk', 'wx', 'qt', 'chromium', 'wincairo', 'efl'):
> > +    if platform in ('chromium', 'efl', 'gtk', 'qt', 'wincairo', 'wince', 'wx'):
> >          step.setCommand(step.command + ['--' + platform])
> 
> It would pass --wince option to the build-webkit script.
> But I can't find if build-webkit handles wince option.

I didn't added the --wince option to build-webkit (I need to take care of the EFL port, which uses CMake too).

[David Kilzer (:ddkilzer)]

Comment on attachment 75614 [details]
Patch

r=me

I'll let Patrick set the cq+ flag since this depends on Bug 51642 landing first.

[Patrick R. Gansterer]

Comment on attachment 75614 [details]
Patch

Clearing flags on attachment: 75614

Manually committed r74930: <http://trac.webkit.org/changeset/74930>

[Patrick R. Gansterer]

All reviewed patches have been landed.  Closing bug.

[William Siegrist]

Buildbot updated.