Bug 50523

Summary: [WINCE] Adds a build slave.
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: Tools / TestsAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, wsiegrist
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 51642    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Patrick R. Gansterer
Reported 2010-12-04 12:43:10 PST
see patch
Attachments
Patch (3.44 KB, patch)
2010-12-04 12:58 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2010-12-04 12:58:02 PST
Created attachment 75614 [details] Patch
Eric Seidel (no email)
Comment 2 2010-12-12 02:31:27 PST
_wms should "review" this.
Csaba Osztrogonác
Comment 3 2010-12-13 06:13:22 PST
Comment on attachment 75614 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=75614&action=review > WebKitTools/BuildSlaveSupport/build.webkit.org-config/master.cfg:83 > def appendCustomBuildFlags(step, platform): > - if platform in ('gtk', 'wx', 'qt', 'chromium', 'wincairo', 'efl'): > + if platform in ('chromium', 'efl', 'gtk', 'qt', 'wincairo', 'wince', 'wx'): > step.setCommand(step.command + ['--' + platform]) It would pass --wince option to the build-webkit script. But I can't find if build-webkit handles wince option.
Patrick R. Gansterer
Comment 4 2010-12-13 06:17:30 PST
(In reply to comment #3) > (From update of attachment 75614 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=75614&action=review > > > WebKitTools/BuildSlaveSupport/build.webkit.org-config/master.cfg:83 > > def appendCustomBuildFlags(step, platform): > > - if platform in ('gtk', 'wx', 'qt', 'chromium', 'wincairo', 'efl'): > > + if platform in ('chromium', 'efl', 'gtk', 'qt', 'wincairo', 'wince', 'wx'): > > step.setCommand(step.command + ['--' + platform]) > > It would pass --wince option to the build-webkit script. > But I can't find if build-webkit handles wince option. I didn't added the --wince option to build-webkit (I need to take care of the EFL port, which uses CMake too).
David Kilzer (:ddkilzer)
Comment 5 2011-01-03 12:01:18 PST
Comment on attachment 75614 [details] Patch r=me I'll let Patrick set the cq+ flag since this depends on Bug 51642 landing first.
Patrick R. Gansterer
Comment 6 2011-01-03 13:11:25 PST
Comment on attachment 75614 [details] Patch Clearing flags on attachment: 75614 Manually committed r74930: <http://trac.webkit.org/changeset/74930>
Patrick R. Gansterer
Comment 7 2011-01-03 13:11:52 PST
All reviewed patches have been landed. Closing bug.
William Siegrist
Comment 8 2011-01-03 13:51:32 PST
Buildbot updated.
Note You need to log in before you can comment on or make changes to this bug.