Bug 50509

Summary:	set* methods on MacroAssembler are awfully named.
Product:	WebKit	Reporter:	Gavin Barraclough <barraclough>
Component:	JavaScriptCore	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal
Priority:	P2
Version:	528+ (Nightly build)
Hardware:	PC
OS:	OS X 10.5

Gavin Barraclough

Reported 2010-12-03 18:44:47 PST

Methods set32 and setTest32 compare 32-bit operands, and set a 32-bit results based on the comparison. set8 compares 32-bit operands, and sets an 8-bit result based on the comparison. setTest8 compares 8-bit operands, and sets a 32-bit result based on the comparison. Rename to clarify. set32 -> set32Compare32 setTest32 -> set32Test32 set8 -> set8Compare32 setTest8 -> set32Test8

Attachments
Add attachment proposed patch, testcase, etc.

Gavin Barraclough

Comment 1 2010-12-03 18:47:08 PST

Committed revision 73323.

Note You need to log in before you can comment on or make changes to this bug.