Bug 50501

Summary: Postpone gl delete* calls until shaders/programs are no longer attached
Product: WebKit Reporter: Zhenyao Mo <zmo>
Component: WebGLAssignee: Zhenyao Mo <zmo>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, enne, gman, kbr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
patch kbr: review+, zmo: commit-queue-

Description Zhenyao Mo 2010-12-03 15:55:48 PST
By doing this, chromium command buffer won't have to change its behavior and will pass the conformance test
Comment 1 Zhenyao Mo 2010-12-03 16:05:55 PST
Created attachment 75571 [details]
patch

Manually ran chrome with command buffer, object-deletion-behavior.html is passing with this patch.
Comment 2 Kenneth Russell 2010-12-06 14:21:06 PST
Comment on attachment 75571 [details]
patch

The changes look good, but do the existing layout tests sufficiently cover these code paths?
Comment 3 Zhenyao Mo 2010-12-06 14:38:31 PST
We have object-deletion-behavior.html checked into LayoutTests, which covers this deletion code path.
Comment 4 Kenneth Russell 2010-12-06 14:39:43 PST
Comment on attachment 75571 [details]
patch

OK.
Comment 5 Zhenyao Mo 2010-12-06 15:17:24 PST
Committed r73406: <http://trac.webkit.org/changeset/73406>