Bug 50484

Summary: Rebaseline server: use pretty text diff output
Product: WebKit Reporter: Mihai Parparita <mihai>
Component: Tools / TestsAssignee: Mihai Parparita <mihai>
Status: RESOLVED FIXED    
Severity: Normal CC: tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 47761    
Attachments:
Description Flags
Patch tony: review+

Description Mihai Parparita 2010-12-03 13:58:00 PST
Rebaseline server: use pretty text diff output
Comment 1 Mihai Parparita 2010-12-03 14:06:26 PST
Created attachment 75540 [details]
Patch
Comment 2 Tony Chang 2010-12-03 14:22:12 PST
Comment on attachment 75540 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=75540&action=review

> WebKitTools/Scripts/webkitpy/tool/commands/rebaselineserver.py:177
> +        elif mode == 'diff-text-pretty':
> +            file_name = test_name + '-pretty-diff.html'

I normally use dictionaries for stuff like this. E.g.:
suffix = { 'expected-text': '-expected.txt',
  'actual-text': '-actual.txt',
  ...
}[mode]
file_name = test_name + suffix

But I don't feel strongly about it and this case is a bit awkward because it's a suffix.
Comment 3 Mihai Parparita 2010-12-03 17:46:34 PST
Committed r73320: <http://trac.webkit.org/changeset/73320>