Bug 50484

Summary: Rebaseline server: use pretty text diff output
Product: WebKit Reporter: Mihai Parparita <mihaip>
Component: Tools / TestsAssignee: Mihai Parparita <mihaip>
Status: RESOLVED FIXED    
Severity: Normal CC: tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 47761    
Attachments:
Description Flags
Patch tony: review+

Mihai Parparita
Reported 2010-12-03 13:58:00 PST
Rebaseline server: use pretty text diff output
Attachments
Patch (4.21 KB, patch)
2010-12-03 14:06 PST, Mihai Parparita 		tony: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mihai Parparita
Comment 1 2010-12-03 14:06:26 PST
Created attachment 75540 [details] Patch
Tony Chang
Comment 2 2010-12-03 14:22:12 PST
Comment on attachment 75540 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=75540&action=review > WebKitTools/Scripts/webkitpy/tool/commands/rebaselineserver.py:177 > + elif mode == 'diff-text-pretty': > + file_name = test_name + '-pretty-diff.html' I normally use dictionaries for stuff like this. E.g.: suffix = { 'expected-text': '-expected.txt', 'actual-text': '-actual.txt', ... }[mode] file_name = test_name + suffix But I don't feel strongly about it and this case is a bit awkward because it's a suffix.
Mihai Parparita
Comment 3 2010-12-03 17:46:34 PST
Committed r73320: <http://trac.webkit.org/changeset/73320>
Note You need to log in before you can comment on or make changes to this bug.