Bug 50484 - Rebaseline server: use pretty text diff output
Summary: Rebaseline server: use pretty text diff output
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Mihai Parparita
Depends on:
Blocks: 47761
  Show dependency treegraph
Reported: 2010-12-03 13:58 PST by Mihai Parparita
Modified: 2010-12-03 17:46 PST (History)
1 user (show)

See Also:

Patch (4.21 KB, patch)
2010-12-03 14:06 PST, Mihai Parparita
tony: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mihai Parparita 2010-12-03 13:58:00 PST
Rebaseline server: use pretty text diff output
Comment 1 Mihai Parparita 2010-12-03 14:06:26 PST
Created attachment 75540 [details]
Comment 2 Tony Chang 2010-12-03 14:22:12 PST
Comment on attachment 75540 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=75540&action=review

> WebKitTools/Scripts/webkitpy/tool/commands/rebaselineserver.py:177
> +        elif mode == 'diff-text-pretty':
> +            file_name = test_name + '-pretty-diff.html'

I normally use dictionaries for stuff like this. E.g.:
suffix = { 'expected-text': '-expected.txt',
  'actual-text': '-actual.txt',
file_name = test_name + suffix

But I don't feel strongly about it and this case is a bit awkward because it's a suffix.
Comment 3 Mihai Parparita 2010-12-03 17:46:34 PST
Committed r73320: <http://trac.webkit.org/changeset/73320>