Bug 50482

Summary: Crash trying to empty caches with no WebProcess.
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit2Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proprosed fix v1
sam: review-
Fix v2 sam: review+, beidson: commit-queue-

Brady Eidson
Reported 2010-12-03 13:48:56 PST
We crash trying to empty caches in a WKContext with no WebProcess. In radar as <rdar://problem/8725679>
Attachments
Proprosed fix v1 (4.05 KB, patch)
2010-12-03 13:51 PST, Brady Eidson 		sam: review-
DetailsFormatted DiffDiff
Fix v2 (5.36 KB, patch)
2010-12-03 14:00 PST, Brady Eidson 		sam: review+
beidson: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2010-12-03 13:51:44 PST
Created attachment 75538 [details] Proprosed fix v1
Sam Weinig
Comment 2 2010-12-03 13:53:39 PST
Comment on attachment 75538 [details] Proprosed fix v1 View in context: https://bugs.webkit.org/attachment.cgi?id=75538&action=review > WebKit2/UIProcess/WebContext.cpp:182 > + if (m_clearResourceCachesForNewWebProcess) { > + m_process->send(Messages::WebProcess::ClearResourceCaches(), 0); > + m_clearResourceCachesForNewWebProcess = false; > + } > + > + if (m_clearApplicationCacheForNewWebProcess) { > + m_process->send(Messages::WebProcess::ClearApplicationCache(), 0); > + m_clearApplicationCacheForNewWebProcess = false; > + } This should use the process initialization message idiom used above in this function, instead of sending its own messages.
Brady Eidson
Comment 3 2010-12-03 14:00:59 PST
Created attachment 75539 [details] Fix v2
Brady Eidson
Comment 4 2010-12-03 14:07:05 PST
http://trac.webkit.org/changeset/73299
Note You need to log in before you can comment on or make changes to this bug.