Bug 50464

Summary: Clean up some text-related code on GraphicsContext
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: PlatformAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, kling, krit, simon.fraser, webkit.review.bot, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on: 50474    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch krit: review+

Simon Fraser (smfr)
Reported 2010-12-03 10:59:52 PST
Cleanup coming.
Attachments
Patch (34.94 KB, patch)
2010-12-03 11:36 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (34.93 KB, patch)
2010-12-03 11:37 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (3.31 KB, patch)
2010-12-03 11:52 PST, Simon Fraser (smfr) 		krit: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2010-12-03 11:36:15 PST
Created attachment 75517 [details] Patch
Simon Fraser (smfr)
Comment 2 2010-12-03 11:37:59 PST
Created attachment 75518 [details] Patch
Nikolas Zimmermann
Comment 3 2010-12-03 11:52:12 PST
Comment on attachment 75518 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=75518&action=review Looks great, r=me. > WebCore/platform/graphics/chromium/FontLinux.cpp:656 > + bool stroke = (textMode & TextModeStroke) Superfluous braces.
Simon Fraser (smfr)
Comment 4 2010-12-03 11:52:59 PST
Created attachment 75520 [details] Patch
Simon Fraser (smfr)
Comment 5 2010-12-03 12:09:03 PST
Comment on attachment 75518 [details] Patch http://trac.webkit.org/changeset/73284
Dirk Schulze
Comment 6 2010-12-03 12:23:48 PST
Comment on attachment 75520 [details] Patch LGTM. r=me
WebKit Review Bot
Comment 7 2010-12-03 12:25:05 PST
Attachment 75518 [details] did not build on chromium: Build output: http://queues.webkit.org/results/6728031
Simon Fraser (smfr)
Comment 8 2010-12-03 13:12:38 PST
http://trac.webkit.org/changeset/73292
Note You need to log in before you can comment on or make changes to this bug.