Bug 50426

Summary: Need to move all code that applies correction into correction panel callback.
Product: WebKit Reporter: Jia Pu <jiapu.mail>
Component: New BugsAssignee: Jia Pu <jiapu.mail>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, darin, dglazkov, mitz, webkit-ews, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.6   
Attachments:
Description Flags
Proposed patch (v1)
none
Proposed patch (v2)
none
Proposed patch (v3) none

Jia Pu
Reported 2010-12-02 17:02:00 PST
This change is necessary for WebKit to work with next AppKit build. More specifically, this means all calls to applyCorrectionPanelInfo() need to be moved into Editor::handleCorrectionPanelResult().
Attachments
Proposed patch (v1) (65.03 KB, patch)
2010-12-02 19:17 PST, Jia Pu 		no flags
DetailsFormatted DiffDiff
Proposed patch (v2) (65.03 KB, patch)
2010-12-02 19:24 PST, Jia Pu 		no flags
DetailsFormatted DiffDiff
Proposed patch (v3) (66.50 KB, patch)
2010-12-02 23:33 PST, Jia Pu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jia Pu
Comment 1 2010-12-02 17:07:48 PST
<rdar://problem/8720832>
Jia Pu
Comment 2 2010-12-02 19:17:32 PST
Created attachment 75452 [details] Proposed patch (v1)
Jia Pu
Comment 3 2010-12-02 19:24:11 PST
Created attachment 75454 [details] Proposed patch (v2) Fixed a typo.
Early Warning System Bot
Comment 4 2010-12-02 19:31:46 PST
Attachment 75452 [details] did not build on qt: Build output: http://queues.webkit.org/results/6818012
WebKit Review Bot
Comment 5 2010-12-02 19:39:58 PST
Attachment 75452 [details] did not build on chromium: Build output: http://queues.webkit.org/results/6803026
Early Warning System Bot
Comment 6 2010-12-02 19:50:45 PST
Attachment 75454 [details] did not build on qt: Build output: http://queues.webkit.org/results/6729027
Build Bot
Comment 7 2010-12-02 20:05:50 PST
Attachment 75452 [details] did not build on win: Build output: http://queues.webkit.org/results/6745017
Build Bot
Comment 8 2010-12-02 20:16:31 PST
Attachment 75454 [details] did not build on win: Build output: http://queues.webkit.org/results/6814019
WebKit Review Bot
Comment 9 2010-12-02 20:23:35 PST
Attachment 75454 [details] did not build on chromium: Build output: http://queues.webkit.org/results/6779017
Jia Pu
Comment 10 2010-12-02 23:33:06 PST
Created attachment 75468 [details] Proposed patch (v3) Fixed build failures.
Darin Adler
Comment 11 2010-12-03 09:55:47 PST
Comment on attachment 75468 [details] Proposed patch (v3) Looks OK.
Jia Pu
Comment 12 2010-12-03 10:02:57 PST
Comment on attachment 75468 [details] Proposed patch (v3) Thanks for reviewing, Darin. Could you cq+ it?
WebKit Commit Bot
Comment 13 2010-12-03 12:45:52 PST
Comment on attachment 75468 [details] Proposed patch (v3) Clearing flags on attachment: 75468 Committed r73287: <http://trac.webkit.org/changeset/73287>
WebKit Commit Bot
Comment 14 2010-12-03 12:45:58 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.