Summary: | Need to move all code that applies correction into correction panel callback. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jia Pu <jiapu.mail> | ||||||||
Component: | New Bugs | Assignee: | Jia Pu <jiapu.mail> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, darin, dglazkov, mitz, webkit-ews, webkit.review.bot | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Mac | ||||||||||
OS: | OS X 10.6 | ||||||||||
Attachments: |
|
Description
Jia Pu
2010-12-02 17:02:00 PST
Created attachment 75452 [details]
Proposed patch (v1)
Created attachment 75454 [details]
Proposed patch (v2)
Fixed a typo.
Attachment 75452 [details] did not build on qt: Build output: http://queues.webkit.org/results/6818012 Attachment 75452 [details] did not build on chromium: Build output: http://queues.webkit.org/results/6803026 Attachment 75454 [details] did not build on qt: Build output: http://queues.webkit.org/results/6729027 Attachment 75452 [details] did not build on win: Build output: http://queues.webkit.org/results/6745017 Attachment 75454 [details] did not build on win: Build output: http://queues.webkit.org/results/6814019 Attachment 75454 [details] did not build on chromium: Build output: http://queues.webkit.org/results/6779017 Created attachment 75468 [details]
Proposed patch (v3)
Fixed build failures.
Comment on attachment 75468 [details]
Proposed patch (v3)
Looks OK.
Comment on attachment 75468 [details]
Proposed patch (v3)
Thanks for reviewing, Darin. Could you cq+ it?
Comment on attachment 75468 [details] Proposed patch (v3) Clearing flags on attachment: 75468 Committed r73287: <http://trac.webkit.org/changeset/73287> All reviewed patches have been landed. Closing bug. |