Bug 50421

Summary: Rebaseline server: move existing baselines
Product: WebKit Reporter: Mihai Parparita <mihaip>
Component: Tools / TestsAssignee: Mihai Parparita <mihaip>
Status: RESOLVED FIXED    
Severity: Normal CC: tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 47761    
Attachments:
Description Flags
Patch
none
Patch tony: review+

Mihai Parparita
Reported 2010-12-02 16:44:39 PST
Rebaseline server: move existing baselines
Attachments
Patch (10.01 KB, patch)
2010-12-02 16:48 PST, Mihai Parparita 		no flags
DetailsFormatted DiffDiff
Patch (10.71 KB, patch)
2010-12-03 10:14 PST, Mihai Parparita 		tony: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mihai Parparita
Comment 1 2010-12-02 16:48:28 PST
Created attachment 75431 [details] Patch
Eric Seidel (no email)
Comment 2 2010-12-02 17:28:33 PST
Comment on attachment 75431 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=75431&action=review > WebKitTools/Scripts/webkitpy/tool/commands/rebaselineserver.py:281 > + # Do the actual move. > + if extensions_to_move: > + extensions_to_move = list(extensions_to_move) Seems like helper functions could make this clearer. :)
Tony Chang
Comment 3 2010-12-03 09:59:22 PST
Comment on attachment 75431 [details] Patch based on eseidel's feedback
Mihai Parparita
Comment 4 2010-12-03 10:14:38 PST
Created attachment 75506 [details] Patch Made moving of baselines be in _move_test_baselines
Mihai Parparita
Comment 5 2010-12-03 10:35:49 PST
Committed r73274: <http://trac.webkit.org/changeset/73274>
Note You need to log in before you can comment on or make changes to this bug.