Bug 50395

Summary: [EFL] Fails to build with non-system cairo
Product: WebKit Reporter: Gustavo Noronha (kov) <gustavo>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, leandro
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
proposed fix none

Gustavo Noronha (kov)
Reported 2010-12-02 09:30:45 PST
While trying to build WebKitEFL with a custom-built cairo, I noticed it was not working. The problem seems to be that FindCairo declares a PATH_SUFFIX, which is added to the end of each PATH given, which causes it to look for ${include_directory_provided_by_pkgconfig}/cairo/cairo.h - which translates to ${prefix}/include/cairo/cairo/cairo.h. I'm attaching a patch that fixes it.
Attachments
proposed fix (1.27 KB, patch)
2010-12-02 09:34 PST, Gustavo Noronha (kov) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gustavo Noronha (kov)
Comment 1 2010-12-02 09:34:14 PST
Created attachment 75388 [details] proposed fix
Leandro Pereira
Comment 2 2010-12-02 09:37:04 PST
Looks good to me.
Eric Seidel (no email)
Comment 3 2010-12-02 17:31:10 PST
Comment on attachment 75388 [details] proposed fix OK. I'm certainly no expert here, but I believe you.
WebKit Commit Bot
Comment 4 2010-12-02 23:06:05 PST
Comment on attachment 75388 [details] proposed fix Clearing flags on attachment: 75388 Committed r73242: <http://trac.webkit.org/changeset/73242>
WebKit Commit Bot
Comment 5 2010-12-02 23:06:10 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.