Bug 50378

Summary: Enable DEP at runtime to allow for compatibility with older versions of ATL
Product: WebKit Reporter: Steve Falkenburg <sfalken>
Component: New BugsAssignee: Steve Falkenburg <sfalken>
Status: RESOLVED FIXED    
Severity: Normal CC: alice.barraclough
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch aroben: review+

Steve Falkenburg
Reported 2010-12-02 00:58:30 PST
Enable DEP at runtime to allow for compatibility with older versions of ATL
Attachments
Patch (2.43 KB, patch)
2010-12-02 01:04 PST, Steve Falkenburg
aroben: review+
Steve Falkenburg
Comment 1 2010-12-02 01:04:58 PST
Adam Roben (:aroben)
Comment 2 2010-12-02 09:07:04 PST
Comment on attachment 75359 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=75359&action=review > WebKit2/WebProcess/win/WebProcessMainWin.cpp:45 > + const DWORD disableATLThunkEmulation = 0x00000002; Maybe we don't need to declare this, since we don't use it? > WebKit2/WebProcess/win/WebProcessMainWin.cpp:47 > + HMODULE hMod = GetModuleHandleW(L"Kernel32.dll"); Please add a :: here. > WebKit2/WebProcess/win/WebProcessMainWin.cpp:53 > + PSETDEP procSet = reinterpret_cast<PSETDEP>(GetProcAddress(hMod, "SetProcessDEPPolicy")); And here. > WebKit2/WebProcess/win/WebProcessMainWin.cpp:83 > + enableDataExecutionPrevention(); Seems like this should go in WebKitMain instead. We already have similar code there.
Adam Roben (:aroben)
Comment 3 2010-12-02 09:08:29 PST
Comment on attachment 75359 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=75359&action=review >> WebKit2/WebProcess/win/WebProcessMainWin.cpp:83 >> + enableDataExecutionPrevention(); > > Seems like this should go in WebKitMain instead. We already have similar code there. By putting it in WebKitMain it will get used by the plugin process, too (once we have one).
Steve Falkenburg
Comment 4 2010-12-02 09:10:58 PST
Note You need to log in before you can comment on or make changes to this bug.