Bug 50377 – [chromium] Remove dead code from PNG encoder

• Component: Canvas
• Status: RESOLVED FIXED

[noel gordon]

Remove dead code, and webkit style these files.

[noel gordon]

Created attachment 75358 [details]
patch

[David Levin]

Comment on attachment 75358 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=75358&action=review

> WebCore/platform/image-encoders/skia/PNGImageEncoder.cpp:2
> + * Copyright (c) 2010, Google Inc. All rights reserved.

fwiw for some reason, WebKit tends to keep all the years (as opposed to Chromium which only keeps the most recent). Also, the years are comma separated and no comma after the last. While this style is followed regularly, I'll admit that this is a super minor issue, so this is fine for this change.

[WebKit Commit Bot]

Comment on attachment 75358 [details]
patch

Rejecting patch 75358 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 1
ERROR: Working directory has local commits, pass --force-clean to continue.

Full output: http://queues.webkit.org/results/6759020

[David Levin]

Comment on attachment 75358 [details]
patch

If at first you don't succeed,...

[Eric Seidel (no email)]

Sigh.  You hit bug 49798.

I'm not sure how we're hitting this so frequently.

[Adam Barth]

That bug shouldn't be that hard to fix.  We just need to force-clean before building.

[Eric Seidel (no email)]

We need to force clean at some point.  Not sure we when exactly, since we don't want to ditch the patch.   I'm not sure how it's ending up with a commit left over.  i assume from a previously failed commit?

[Jian Li]

Committed as http://trac.webkit.org/changeset/73233.