Bug 50377

Summary: [chromium] Remove dead code from PNG encoder
Product: WebKit Reporter: noel gordon <noel.gordon>
Component: CanvasAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, jianli, mdelaney7, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
patch levin: review+

Description noel gordon 2010-12-02 00:29:54 PST
Remove dead code, and webkit style these files.
Comment 1 noel gordon 2010-12-02 00:34:27 PST
Created attachment 75358 [details]
patch
Comment 2 David Levin 2010-12-02 09:35:00 PST
Comment on attachment 75358 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=75358&action=review

> WebCore/platform/image-encoders/skia/PNGImageEncoder.cpp:2
> + * Copyright (c) 2010, Google Inc. All rights reserved.

fwiw for some reason, WebKit tends to keep all the years (as opposed to Chromium which only keeps the most recent). Also, the years are comma separated and no comma after the last. While this style is followed regularly, I'll admit that this is a super minor issue, so this is fine for this change.
Comment 3 WebKit Commit Bot 2010-12-02 11:49:45 PST
Comment on attachment 75358 [details]
patch

Rejecting patch 75358 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 1
ERROR: Working directory has local commits, pass --force-clean to continue.

Full output: http://queues.webkit.org/results/6759020
Comment 4 David Levin 2010-12-02 16:10:09 PST
Comment on attachment 75358 [details]
patch

If at first you don't succeed,...
Comment 5 Eric Seidel (no email) 2010-12-02 16:28:21 PST
Sigh.  You hit bug 49798.

I'm not sure how we're hitting this so frequently.
Comment 6 Adam Barth 2010-12-02 17:09:16 PST
That bug shouldn't be that hard to fix.  We just need to force-clean before building.
Comment 7 Eric Seidel (no email) 2010-12-02 17:16:21 PST
We need to force clean at some point.  Not sure we when exactly, since we don't want to ditch the patch.   I'm not sure how it's ending up with a commit left over.  i assume from a previously failed commit?
Comment 8 Jian Li 2010-12-02 20:36:28 PST
Committed as http://trac.webkit.org/changeset/73233.