Bug 50371

Summary:

Implement focus ring support for image maps

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dbates, gustavo, mrobinson, tonikitoo, webkit.review.bot, xan.lopez

Priority:

Keywords:

Gtk, PlatformOnly

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
[Patch] Part 1 of 2 (GraphicsContext::drawFocusRing(const Path& path, ...))	none
[Patch] Part 2 of 2 (Layout tests and updated results)	mrobinson: review+
[Patch] Part 1 of 2 (GraphicsContext::drawFocusRing(const Path& path, ...))	mrobinson: review+

Daniel Bates

Reported 2010-12-01 21:59:58 PST

We should add support for drawing a focus ring for image maps (i.e. implement GraphicsContext::drawFocusRing(const Path& path, ...)).

Attachments
[Patch] Part 1 of 2 (GraphicsContext::drawFocusRing(const Path& path, ...)) (4.27 KB, patch) 2010-12-01 22:15 PST, Daniel Bates	no flags	Details Formatted Diff Diff
[Patch] Part 2 of 2 (Layout tests and updated results) (235.64 KB, patch) 2010-12-01 22:18 PST, Daniel Bates	mrobinson: review+	Details Formatted Diff Diff
[Patch] Part 1 of 2 (GraphicsContext::drawFocusRing(const Path& path, ...)) (4.29 KB, patch) 2010-12-05 12:13 PST, Daniel Bates	mrobinson: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2010-12-01 22:15:21 PST

Created attachment 75352 [details] [Patch] Part 1 of 2 (GraphicsContext::drawFocusRing(const Path& path, ...)) Part 1 of 2 I thought to break this patch up into two parts so as to make it easier to look over the changes. The first part implements GraphicsContext::drawFocusRing(const Path& path, ...) and the second part includes layout tests. I was unclear how to draw paths that describe a rectangular focus ring (e.g. <area shape="rect" ...>) with rounded corners using the Cairo/GTK API. Further investigation is needed. If anyone can save me some time with some insight/suggestions, I would appreciate it.

Daniel Bates

Comment 2 2010-12-01 22:18:58 PST

Created attachment 75353 [details] [Patch] Part 2 of 2 (Layout tests and updated results) Part 2 of 2. Added tests fast/images/imagemap-circle-focus-ring.html and fast/images/imagemap-polygon-focus-ring.html. Generated render-tree dumps/pixel-test results for fast/images/imagemap-focus-ring.html, fast/images/imagemap-focus-ring-outline-color.html, fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map.html, and fast/images/imagemap-focus-ring-zoom.html.

Daniel Bates

Comment 3 2010-12-05 12:13:31 PST

Created attachment 75637 [details] [Patch] Part 1 of 2 (GraphicsContext::drawFocusRing(const Path& path, ...)) Rebased patch for part 1 since it became stale.

Martin Robinson

Comment 4 2010-12-07 01:24:56 PST

Comment on attachment 75637 [details] [Patch] Part 1 of 2 (GraphicsContext::drawFocusRing(const Path& path, ...)) Thank you!

WebKit Review Bot

Comment 5 2010-12-07 20:27:08 PST

Attachment 75637 [details] did not build on gtk: Build output: http://queues.webkit.org/results/6788077

Daniel Bates

Comment 6 2010-12-07 20:50:18 PST

Committed r73490: <http://trac.webkit.org/changeset/73490>

Note You need to log in before you can comment on or make changes to this bug.