Bug 50343

Summary: AudioContext needs createBuffer() method from ArrayBuffer
Product: WebKit Reporter: Chris Rogers <crogers>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch kbr: review+, crogers: commit-queue-

Chris Rogers
Reported 2010-12-01 12:09:03 PST
AudioContext needs createBuffer() method from ArrayBuffer
Attachments
Patch (4.98 KB, patch)
2010-12-01 12:20 PST, Chris Rogers 		kbr: review+
crogers: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Rogers
Comment 1 2010-12-01 12:20:18 PST
Created attachment 75302 [details] Patch
Kenneth Russell
Comment 2 2010-12-01 13:06:27 PST
Comment on attachment 75302 [details] Patch Looks good. I assume CachedAudio wasn't landed yet (I don't see it in the tree). If it is, it should be deleted in this patch as well.
Chris Rogers
Comment 3 2010-12-01 13:08:40 PST
CachedAudio was never landed, so it didn't even compile before. So we'll be fine there.
Chris Rogers
Comment 4 2010-12-02 11:34:20 PST
Comment on attachment 75302 [details] Patch removing from commit queue and landing manually
Eric Seidel (no email)
Comment 5 2010-12-02 11:39:39 PST
You'll always win if you race the queue, btw. But it's a good idea to remove things from teh queue if you want to make further mods for sure. :)
Chris Rogers
Comment 6 2010-12-02 11:49:13 PST
Committed r73174: <http://trac.webkit.org/changeset/73174>
Note You need to log in before you can comment on or make changes to this bug.