Bug 50343 - AudioContext needs createBuffer() method from ArrayBuffer
Summary: AudioContext needs createBuffer() method from ArrayBuffer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-01 12:09 PST by Chris Rogers
Modified: 2010-12-02 11:49 PST (History)
2 users (show)

See Also:


Attachments
Patch (4.98 KB, patch)
2010-12-01 12:20 PST, Chris Rogers
kbr: review+
crogers: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rogers 2010-12-01 12:09:03 PST
AudioContext needs createBuffer() method from ArrayBuffer
Comment 1 Chris Rogers 2010-12-01 12:20:18 PST
Created attachment 75302 [details]
Patch
Comment 2 Kenneth Russell 2010-12-01 13:06:27 PST
Comment on attachment 75302 [details]
Patch

Looks good. I assume CachedAudio wasn't landed yet (I don't see it in the tree). If it is, it should be deleted in this patch as well.
Comment 3 Chris Rogers 2010-12-01 13:08:40 PST
CachedAudio was never landed, so it didn't even compile before.  So we'll be fine there.
Comment 4 Chris Rogers 2010-12-02 11:34:20 PST
Comment on attachment 75302 [details]
Patch

removing from commit queue and landing manually
Comment 5 Eric Seidel (no email) 2010-12-02 11:39:39 PST
You'll always win if you race the queue, btw.  But it's a good idea to remove things from teh queue if you want to make further mods for sure. :)
Comment 6 Chris Rogers 2010-12-02 11:49:13 PST
Committed r73174: <http://trac.webkit.org/changeset/73174>