| Summary: | build-webkit --chromium always updates DEPS and re-generates project files | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mihai Parparita <mihaip> | ||||||
| Component: | Tools / Tests | Assignee: | Mihai Parparita <mihaip> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, dbates, eric, tony, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Mihai Parparita
2010-12-01 11:38:15 PST
Created attachment 75298 [details]
Patch
Comment on attachment 75298 [details]
Patch
Yay!
I'll give Adam and Eric a chance to say no :) I support this idea. :) Comment on attachment 75298 [details]
Patch
This will break the Chromium EWS bot when folks modify GYP or DEPs files in their patch. Can you change the build command used by the bot to pass this new flag?
Created attachment 75322 [details]
Patch
Comment on attachment 75322 [details]
Patch
Thanks!
I'm surprised that doesn't break any webkitpy unit tests.
(In reply to comment #7) > I'm surprised that doesn't break any webkitpy unit tests. Ah, good point. WebKitPortTest.test_chromium_port did need to be updated. Will fix and land. Committed r73082: <http://trac.webkit.org/changeset/73082> http://trac.webkit.org/changeset/73082 might have broken SnowLeopard Intel Release (Tests) (In reply to comment #10) > http://trac.webkit.org/changeset/73082 might have broken SnowLeopard Intel Release (Tests) fast/profiler/throw-exception-from-eval.html has diffs in the stack trace that's output, I don't see how this could cause that. |