Bug 50340

Summary: build-webkit --chromium always updates DEPS and re-generates project files
Product: WebKit Reporter: Mihai Parparita <mihaip>
Component: Tools / TestsAssignee: Mihai Parparita <mihaip>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dbates, eric, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch abarth: review+

Mihai Parparita
Reported 2010-12-01 11:38:15 PST
build-webkit --chromium always updates DEPS and re-generates project files
Attachments
Patch (2.45 KB, patch)
2010-12-01 11:47 PST, Mihai Parparita 		no flags
DetailsFormatted DiffDiff
Patch (3.17 KB, patch)
2010-12-01 14:11 PST, Mihai Parparita 		abarth: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mihai Parparita
Comment 1 2010-12-01 11:47:12 PST
Created attachment 75298 [details] Patch
Tony Chang
Comment 2 2010-12-01 11:53:00 PST
Comment on attachment 75298 [details] Patch Yay!
Mihai Parparita
Comment 3 2010-12-01 11:54:44 PST
I'll give Adam and Eric a chance to say no :)
Eric Seidel (no email)
Comment 4 2010-12-01 12:36:43 PST
I support this idea. :)
Adam Barth
Comment 5 2010-12-01 12:46:17 PST
Comment on attachment 75298 [details] Patch This will break the Chromium EWS bot when folks modify GYP or DEPs files in their patch. Can you change the build command used by the bot to pass this new flag?
Mihai Parparita
Comment 6 2010-12-01 14:11:10 PST
Created attachment 75322 [details] Patch
Adam Barth
Comment 7 2010-12-01 15:38:34 PST
Comment on attachment 75322 [details] Patch Thanks! I'm surprised that doesn't break any webkitpy unit tests.
Mihai Parparita
Comment 8 2010-12-01 15:47:18 PST
(In reply to comment #7) > I'm surprised that doesn't break any webkitpy unit tests. Ah, good point. WebKitPortTest.test_chromium_port did need to be updated. Will fix and land.
Mihai Parparita
Comment 9 2010-12-01 16:04:16 PST
Committed r73082: <http://trac.webkit.org/changeset/73082>
WebKit Review Bot
Comment 10 2010-12-01 16:49:03 PST
http://trac.webkit.org/changeset/73082 might have broken SnowLeopard Intel Release (Tests)
Mihai Parparita
Comment 11 2010-12-01 16:58:03 PST
(In reply to comment #10) > http://trac.webkit.org/changeset/73082 might have broken SnowLeopard Intel Release (Tests) fast/profiler/throw-exception-from-eval.html has diffs in the stack trace that's output, I don't see how this could cause that.
Note You need to log in before you can comment on or make changes to this bug.