Summary: | Missing DOM property for incremental input attribute | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Erik Arvidsson <arv> | ||||||
Component: | Forms | Assignee: | Erik Arvidsson <arv> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Minor | CC: | commit-queue, darin, tkent | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Erik Arvidsson
2010-12-01 10:40:07 PST
Created attachment 75332 [details]
Patch
Comment on attachment 75332 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=75332&action=review review- because I would prefer that we not add unused functions to the class. Now that we have Reflect, we don’t need to write C++ getters and setters for most attributes, although there are exceptions. > WebCore/html/HTMLInputElement.cpp:1586 > +bool HTMLInputElement::incremental() const > +{ > + return fastHasAttribute(incrementalAttr); > +} > + > +void HTMLInputElement::setIncremental(bool incremental) > +{ > + setBooleanAttribute(incrementalAttr, incremental); > +} These are not needed. No reason to add these. > WebCore/html/HTMLInputElement.h:198 > + bool incremental() const; > + void setIncremental(bool); These are not needed. No reason to add these. > WebCore/html/HTMLInputElement.idl:73 > + attribute [Reflect] boolean incremental; This is enough to fix the bug. Created attachment 75335 [details]
Patch
Comment on attachment 75335 [details] Patch Clearing flags on attachment: 75335 Committed r73168: <http://trac.webkit.org/changeset/73168> All reviewed patches have been landed. Closing bug. |