Bug 50335 – Missing DOM property for incremental input attribute

• Component: Forms
• Status: RESOLVED FIXED

[Erik Arvidsson]

There should be a DOM property that maps to the incremental input attribute.

[Erik Arvidsson]

Created attachment 75332 [details]
Patch

[Darin Adler]

Comment on attachment 75332 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=75332&action=review

review- because I would prefer that we not add unused functions to the class. Now that we have Reflect, we don’t need to write C++ getters and setters for most attributes, although there are exceptions.

> WebCore/html/HTMLInputElement.cpp:1586
> +bool HTMLInputElement::incremental() const
> +{
> +    return fastHasAttribute(incrementalAttr);
> +}
> +
> +void HTMLInputElement::setIncremental(bool incremental)
> +{
> +    setBooleanAttribute(incrementalAttr, incremental);
> +}

These are not needed. No reason to add these.

> WebCore/html/HTMLInputElement.h:198
> +    bool incremental() const;
> +    void setIncremental(bool);

These are not needed. No reason to add these.

> WebCore/html/HTMLInputElement.idl:73
> +        attribute [Reflect] boolean incremental;

This is enough to fix the bug.

[Erik Arvidsson]

Created attachment 75335 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 75335 [details]
Patch

Clearing flags on attachment: 75335

Committed r73168: <http://trac.webkit.org/changeset/73168>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.