Bug 50304

Summary: Web Inspector: do not make helpScreen.css lazily loaded.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed change yurys: review+, yurys: commit-queue+

Description Pavel Feldman 2010-11-30 17:50:20 PST
Otherwise it blinks. Patch to follow.

helpScreen.css is only 150 lines, with primitive selectors only.
Comment 1 Pavel Feldman 2010-11-30 17:52:50 PST
Created attachment 75238 [details]
[PATCH] Proposed change
Comment 2 Timothy Hatcher 2010-11-30 20:31:08 PST
You could fix this by listening for the load event on the link element and aiting to show the help element until it is loaded.
Comment 3 Pavel Feldman 2010-12-01 07:54:41 PST
(In reply to comment #2)
> You could fix this by listening for the load event on the link element and aiting to show the help element until it is loaded.

I am thinking of iframe-ifying parts of the inspector (i.e. hosting TextViewer in iframe as originally was with SourceFrame, hosting network log in iframe, maybe help screen). The rationale is that number of the css rules multiplied by the size of the dom makes us render slowly. Localized doms with localized styles will be a better fit... 

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/HelpScreen.js
	M	WebCore/inspector/front-end/inspector.html
Committed r73021