Bug 50302

Summary:

Text search should treat all matches as word-start matches when the target begins with a separator character

Product:

WebKit

Reporter:

mitz

Component:

HTML Editing

Assignee:

mitz

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	darin: review+

Description mitz 2010-11-30 17:27:46 PST

Text search should treat all matches as word-start matches when the target begins with a separator character

Comment 1 mitz 2010-11-30 17:31:33 PST

Created attachment 75237 [details]
Patch

Comment 2 Darin Adler 2010-11-30 17:34:40 PST

Comment on attachment 75237 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=75237&action=review

> WebCore/editing/TextIterator.cpp:1897
> +    if (m_options & AtWordStarts && targetLength) {
> +        UChar32 targetFirstCharacter;
> +        U16_GET(m_target.characters(), 0, 0, m_target.length(), targetFirstCharacter);

You probably need parentheses to avoid annoying newest gcc.

Why not use targetLength here instead of m_target.length()?

> WebCore/editing/TextIterator.cpp:1898
> +        // Characters in the separator category are never really occur at the beginning of a word,

"are never really occur" is wrong -- I suggest removing a word

Comment 3 mitz 2010-11-30 17:50:19 PST

Fixed in <http://trac.webkit.org/projects/webkit/changeset/72989>.

Comment 4 WebKit Review Bot 2010-11-30 18:31:50 PST

http://trac.webkit.org/changeset/72989 might have broken Qt Linux ARMv7 Release