Bug 50302 – Text search should treat all matches as word-start matches when the target begins with a separator character

• Component: HTML Editing
• Status: RESOLVED FIXED

Text search should treat all matches as word-start matches when the target begins with a separator character

Created attachment 75237 [details]
Patch

[Darin Adler]

Comment on attachment 75237 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=75237&action=review

> WebCore/editing/TextIterator.cpp:1897
> +    if (m_options & AtWordStarts && targetLength) {
> +        UChar32 targetFirstCharacter;
> +        U16_GET(m_target.characters(), 0, 0, m_target.length(), targetFirstCharacter);

You probably need parentheses to avoid annoying newest gcc.

Why not use targetLength here instead of m_target.length()?

> WebCore/editing/TextIterator.cpp:1898
> +        // Characters in the separator category are never really occur at the beginning of a word,

"are never really occur" is wrong -- I suggest removing a word

Fixed in <http://trac.webkit.org/projects/webkit/changeset/72989>.

[WebKit Review Bot]

http://trac.webkit.org/changeset/72989 might have broken Qt Linux ARMv7 Release