| Summary: | [OpenVG] Remove "current path" of GraphicsContext | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Patrick R. Gansterer <paroga> | ||||||
| Component: | Platform | Assignee: | Patrick R. Gansterer <paroga> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | jpetsovits, kling | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Other | ||||||||
| OS: | Other | ||||||||
| Bug Depends on: | 48516 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Patrick R. Gansterer
2010-11-30 16:47:18 PST
Created attachment 75226 [details]
Patch
Comment on attachment 75226 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=75226&action=review Big fan of the patch overall! Just two minor nitpicks from my side (I'm not a reviewer though). > WebCore/platform/graphics/openvg/PainterOpenVG.cpp:733 > + path.platformPath()->makeCompatibleContextCurrent(); This is not necessary. We want the surface current that's being drawn on, and need to expect the path to be compatible to that surface, otherwise we won't get anything drawn anyways. > WebCore/platform/graphics/openvg/PainterOpenVG.h:139 > +} // namespace WebCore On his initial review, Niko advised me against these labels, indicating that it's probably "better" WebKit coding style. I'd say leave it like that, because there's no good reason to change and it doesn't thematically belong in this commit. Created attachment 75261 [details]
Patch
Comment on attachment 75261 [details]
Patch
patch won't apply, I'll commit it manually
Comment on attachment 75261 [details] Patch Clearing flags on attachment: 75261 Manually committed r73184: <http://trac.webkit.org/changeset/73184> All reviewed patches have been landed. Closing bug. |