Bug 50294

Summary: [OpenVG] Remove "current path" of GraphicsContext
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: PlatformAssignee: Patrick R. Gansterer <paroga>
Severity: Normal CC: jpetsovits, kling
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Bug Depends on: 48516    
Bug Blocks:    
Description Flags
Patch none

Description Patrick R. Gansterer 2010-11-30 16:47:18 PST
see patch
Comment 1 Patrick R. Gansterer 2010-11-30 16:49:10 PST
Created attachment 75226 [details]
Comment 2 Jakob Petsovits 2010-11-30 17:50:07 PST
Comment on attachment 75226 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=75226&action=review

Big fan of the patch overall! Just two minor nitpicks from my side (I'm not a reviewer though).

> WebCore/platform/graphics/openvg/PainterOpenVG.cpp:733
> +    path.platformPath()->makeCompatibleContextCurrent();

This is not necessary. We want the surface current that's being drawn on, and need to expect the path to be compatible to that surface, otherwise we won't get anything drawn anyways.

> WebCore/platform/graphics/openvg/PainterOpenVG.h:139
> +} // namespace WebCore

On his initial review, Niko advised me against these labels, indicating that it's probably "better" WebKit coding style. I'd say leave it like that, because there's no good reason to change and it doesn't thematically belong in this commit.
Comment 3 Patrick R. Gansterer 2010-12-01 00:45:13 PST
Created attachment 75261 [details]
Comment 4 Patrick R. Gansterer 2010-12-02 06:34:01 PST
Comment on attachment 75261 [details]

patch won't apply, I'll commit it manually
Comment 5 Patrick R. Gansterer 2010-12-02 12:43:57 PST
Comment on attachment 75261 [details]

Clearing flags on attachment: 75261

Manually committed r73184: <http://trac.webkit.org/changeset/73184>
Comment 6 Patrick R. Gansterer 2010-12-02 12:44:20 PST
All reviewed patches have been landed.  Closing bug.