Bug 50292
| Summary: | Port PCRE regex tests to JSC harness / ECMA syntax | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Gavin Barraclough <barraclough> |
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ap |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
Gavin Barraclough
LayoutTests/fast/regex currently contains a number of test cases ported from PCRE's test suites.
There are two key problems with these tests:
* They use their own harness, and cannot be run from jsc without building all of WebKit.
* They expect PCRE expression syntax, including extended syntax, backwards assertions, etc.
Rewrite all tests to comply to ECMA compatible syntax (ish - we support octal escapes), and use the normal 'shouldBe' test style.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Gavin Barraclough
Fixed in r72990.
Alexey Proskuryakov
Gavin, did you check upstream PCRE for any interesting tests that were added since we imported the suite?
Gavin Barraclough
No, I didn't have time to look at this. My guess is that this would be an inefficient way to get high quality JS tests (since most of the PCRE tests seemed to focus on features not supported by ECMAScript). But feel free to give this a shot, if you disagree & think it may be worthwhile.