| Summary: | [chromium] histograms api updated in WebKitClient and added to ChromiumBridge | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Vincent Scheib <scheib> | ||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, fishd | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Vincent Scheib
2010-11-30 16:21:04 PST
Created attachment 75225 [details]
Patch
Comment on attachment 75225 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=75225&action=review > WebCore/platform/chromium/ChromiumBridge.h:242 > + static void histogramCustomCounts(const char* name, int sample, int min, int max, int bucketCount); Why the "custom" modifier? Why not just call this histogramCounts? Comment on attachment 75225 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=75225&action=review >> WebCore/platform/chromium/ChromiumBridge.h:242 >> + static void histogramCustomCounts(const char* name, int sample, int min, int max, int bucketCount); > > Why the "custom" modifier? Why not just call this histogramCounts? This mimics the low level api name used in Chromium HISTOGRAM_CUSTOM_COUNTS, the name HISTOGRAM_COUNTS is used with only two parameters (name, sample). Comment on attachment 75225 [details]
Patch
Ah, R=me
The commit-queue encountered the following flaky tests while processing attachment 75225 [details]: http/tests/misc/copy-resolves-urls.html Please file bugs against the tests. These tests were authored by tony@chromium.org. The commit-queue is continuing to process your patch. Comment on attachment 75225 [details] Patch Clearing flags on attachment: 75225 Committed r73137: <http://trac.webkit.org/changeset/73137> All reviewed patches have been landed. Closing bug. |