Bug 50269

Summary: [Qt] GraphicsContext::strokeRect() taints the context's lineWidth
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, rhodovan.u-szeged
Priority: P2 Keywords: HTML5, Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch none

Andreas Kling
Reported 2010-11-30 13:35:41 PST
GraphicsContext::strokeRect() currently calls setStrokeThickness() without restoring the original value after stroking. This is exposed to the web via a WebKit-specific strokeRect() overload in the Canvas API.
Attachments
Proposed patch (5.49 KB, patch)
2010-11-30 13:40 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2010-11-30 13:40:43 PST
Created attachment 75194 [details] Proposed patch
WebKit Commit Bot
Comment 2 2010-12-02 04:35:25 PST
The commit-queue encountered the following flaky tests while processing attachment 75194 [details]: fast/preloader/script.html fast/loader/recursive-before-unload-crash.html Please file bugs against the tests. These tests were authored by abarth@webkit.org, beidson@apple.com, and eric@webkit.org. The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 3 2010-12-02 05:08:16 PST
The commit-queue encountered the following flaky tests while processing attachment 75194 [details]: fast/images/load-img-with-empty-src.html fast/preloader/script.html Please file bugs against the tests. These tests were authored by abarth@webkit.org and mitz@webkit.org. The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 4 2010-12-02 05:21:34 PST
The commit-queue encountered the following flaky tests while processing attachment 75194 [details]: compositing/reflections/nested-reflection-animated.html animations/play-state-suspend.html Please file bugs against the tests. These tests were authored by cmarrin@apple.com and simon.fraser@apple.com. The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2010-12-02 05:22:21 PST
The commit-queue encountered the following flaky tests while processing attachment 75194 [details]: http/tests/misc/script-async.html java/lc3/JSObject/ToObject-001.html Please file bugs against the tests. These tests were authored by ap@webkit.org and tonyg@chromium.org. The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2010-12-02 05:39:37 PST
Comment on attachment 75194 [details] Proposed patch Clearing flags on attachment: 75194 Committed r73125: <http://trac.webkit.org/changeset/73125>
WebKit Commit Bot
Comment 7 2010-12-02 05:39:43 PST
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 8 2010-12-02 05:51:20 PST
The commit-queue encountered the following flaky tests while processing attachment 75194 [details]: fast/loader/recursive-before-unload-crash.html fast/preloader/script.html Please file bugs against the tests. These tests were authored by abarth@webkit.org, beidson@apple.com, and eric@webkit.org. The commit-queue is continuing to process your patch.
Note You need to log in before you can comment on or make changes to this bug.