| Summary: | [Qt] [WK2] Build system improvements for non-Unix targets | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Siddharth Mathur <s.mathur> | ||||||||
| Component: | WebKit2 | Assignee: | Siddharth Mathur <s.mathur> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Minor | CC: | commit-queue, laszlo.gombos | ||||||||
| Priority: | P3 | Keywords: | Qt | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 50251 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Siddharth Mathur
2010-11-30 11:51:48 PST
Created attachment 75218 [details]
Fix directory seperators for Windows as host
Created attachment 75236 [details]
Updated patch for Windows build host and ARMCC flag
Comment on attachment 75236 [details]
Updated patch for Windows build host and ARMCC flag
This patch does not seems to apply cleanly to the trunk, r- for that.
Also, have you successfully used --preinclude in any environment ? If not than this code is speculative and I think we should not land it until we used it successfully.
Perhaps you can resolve the conflict with the trunk and resubmit the patch without the "--preinclude" changes.
Created attachment 75519 [details]
updated patch with only changes requested by Laszlo
Comment on attachment 75519 [details]
updated patch with only changes requested by Laszlo
looks great, thanks. r+.
Comment on attachment 75519 [details] updated patch with only changes requested by Laszlo Clearing flags on attachment: 75519 Committed r73313: <http://trac.webkit.org/changeset/73313> All reviewed patches have been landed. Closing bug. |