Bug 50229

Summary: Cleanup SVGPropertyTraits
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: SVGAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: krit, mdelaney7, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 47905    
Attachments:
Description Flags
Patch krit: review+

Nikolas Zimmermann
Reported 2010-11-30 05:51:51 PST
SVGPropertyTraits includes several SVG* files, just to declare the template specializations. We can just move the specializations into the SVG* files, and remove all SVG*.h includes from SVGPropertyTraits.h
Attachments
Patch (22.77 KB, patch)
2010-11-30 05:55 PST, Nikolas Zimmermann 		krit: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2010-11-30 05:55:23 PST
Created attachment 75130 [details] Patch
Dirk Schulze
Comment 2 2010-11-30 09:41:14 PST
Comment on attachment 75130 [details] Patch LGTM. r=me
Nikolas Zimmermann
Comment 3 2010-12-01 00:51:39 PST
Fixed all style issues locally, wondering why the style bot didn't post a link here. Chromium EWS does nothing unfortunately, so I'm just risking to land...
Dirk Schulze
Comment 4 2010-12-01 00:56:37 PST
Saw the same problem on other patches. Seems to be a bug in the Style-bot.
Nikolas Zimmermann
Comment 5 2010-12-01 01:03:43 PST
Landed in r73011, closing bug when it builds everywhere.
Nikolas Zimmermann
Comment 6 2010-12-01 02:04:36 PST
Builds just fine, closing bug, marking as blocks 47905, what I forgot before.
Note You need to log in before you can comment on or make changes to this bug.