Bug 50216

Summary: [WINCE] Add WebView
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: PlatformAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
Patch none

Description Patrick R. Gansterer 2010-11-30 02:40:01 PST 
see patch
Comment 1 Patrick R. Gansterer 2010-11-30 02:48:32 PST 
Created attachment 75116 [details]
Patch
Comment 2 Adam Roben (:aroben) 2010-11-30 07:14:41 PST 
Comment on attachment 75116 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=75116&action=review

You have a bunch of unnecessary parameter names in WebView.h.

I'm not sure why the style bot didn't catch the style issues.

> WebKit/wince/WebView.cpp:245
> +    if (::GetUpdateRect(hWnd, &updateRect, false)) {

Can you use an early return here?

> WebKit/wince/WebView.h:61
> +    WebCore::FrameView *view() const;

Misplaced *.

> WebKit/wince/WebView.h:80
> +    static LRESULT CALLBACK WebViewWndProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam);
> +    LRESULT WndProc(HWND, UINT, WPARAM, LPARAM);

These should start with lowercase letters.
Comment 3 Patrick R. Gansterer 2010-11-30 08:30:15 PST 
Comment on attachment 75116 [details]
Patch

Clearing flags on attachment: 75116

Manually committed r72916: <http://trac.webkit.org/changeset/72916>
Comment 4 Patrick R. Gansterer 2010-11-30 08:30:34 PST 
All reviewed patches have been landed.  Closing bug.