Bug 50216

Summary: [WINCE] Add WebView
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: PlatformAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
Patch none

Patrick R. Gansterer
Reported 2010-11-30 02:40:01 PST
see patch
Attachments
Patch (19.49 KB, patch)
2010-11-30 02:48 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2010-11-30 02:48:32 PST
Created attachment 75116 [details] Patch
Adam Roben (:aroben)
Comment 2 2010-11-30 07:14:41 PST
Comment on attachment 75116 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=75116&action=review You have a bunch of unnecessary parameter names in WebView.h. I'm not sure why the style bot didn't catch the style issues. > WebKit/wince/WebView.cpp:245 > + if (::GetUpdateRect(hWnd, &updateRect, false)) { Can you use an early return here? > WebKit/wince/WebView.h:61 > + WebCore::FrameView *view() const; Misplaced *. > WebKit/wince/WebView.h:80 > + static LRESULT CALLBACK WebViewWndProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam); > + LRESULT WndProc(HWND, UINT, WPARAM, LPARAM); These should start with lowercase letters.
Patrick R. Gansterer
Comment 3 2010-11-30 08:30:15 PST
Comment on attachment 75116 [details] Patch Clearing flags on attachment: 75116 Manually committed r72916: <http://trac.webkit.org/changeset/72916>
Patrick R. Gansterer
Comment 4 2010-11-30 08:30:34 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.