Summary: | All projects on Windows should use cmd files for build events | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Steve Falkenburg <sfalken> | ||||
Component: | New Bugs | Assignee: | Steve Falkenburg <sfalken> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aroben | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Steve Falkenburg
2010-11-30 00:25:46 PST
Created attachment 75112 [details]
Patch
Comment on attachment 75112 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=75112&action=review Maybe we should move the which.exe/buildfailed stuff into common.vsprops? > WebKit2/win/WebKitPreBuild.cmd:11 > +cl /analyze /nologo /c "%WEBKITOUTPUTDIR%\tmp.cpp" /Fo"%INTDIR%\tmp.obj" 2>&1 | findstr D9040 > +if ERRORLEVEL 1 (set EnablePREfast="true") else (set EnablePREfast="false") > +if ERRORLEVEL 1 (set AnalyzeWithLargeStack="/analyze:65536") else (set AnalyzeWithLargeStack="") Does anyone use PREfast anymore? Committed r72923: <http://trac.webkit.org/changeset/72923> |