Bug 50213

Summary: All projects on Windows should use cmd files for build events
Product: WebKit Reporter: Steve Falkenburg <sfalken>
Component: New BugsAssignee: Steve Falkenburg <sfalken>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch aroben: review+

Steve Falkenburg
Reported 2010-11-30 00:25:46 PST
All projects on Windows should use cmd files for build events
Attachments
Patch (83.42 KB, patch)
2010-11-30 00:34 PST, Steve Falkenburg 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Steve Falkenburg
Comment 1 2010-11-30 00:34:13 PST
Created attachment 75112 [details] Patch
Adam Roben (:aroben)
Comment 2 2010-11-30 09:12:59 PST
Comment on attachment 75112 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=75112&action=review Maybe we should move the which.exe/buildfailed stuff into common.vsprops? > WebKit2/win/WebKitPreBuild.cmd:11 > +cl /analyze /nologo /c "%WEBKITOUTPUTDIR%\tmp.cpp" /Fo"%INTDIR%\tmp.obj" 2>&1 | findstr D9040 > +if ERRORLEVEL 1 (set EnablePREfast="true") else (set EnablePREfast="false") > +if ERRORLEVEL 1 (set AnalyzeWithLargeStack="/analyze:65536") else (set AnalyzeWithLargeStack="") Does anyone use PREfast anymore?
Steve Falkenburg
Comment 3 2010-11-30 09:53:59 PST
Committed r72923: <http://trac.webkit.org/changeset/72923>
Note You need to log in before you can comment on or make changes to this bug.