Bug 50197

Summary: config.webkit_base_dir returns a path with a trailing slash
Product: WebKit Reporter: Mihai Parparita <mihai>
Component: Tools / TestsAssignee: Mihai Parparita <mihai>
Status: RESOLVED FIXED    
Severity: Normal CC: dpranke, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch tony: review+

Description Mihai Parparita 2010-11-29 18:01:36 PST
config.webkit_base_dir returns a path with a trailing slash
Comment 1 Mihai Parparita 2010-11-29 18:03:37 PST
Created attachment 75094 [details]
Patch
Comment 2 Dirk Pranke 2010-11-29 18:40:31 PST
Comment on attachment 75094 [details]
Patch

Ah. Yep, that would do it. LGTM!
Comment 3 Tony Chang 2010-11-30 09:21:26 PST
Comment on attachment 75094 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=75094&action=review

> WebKitTools/Scripts/webkitpy/layout_tests/port/config.py:135
> +            self._webkit_base_dir = abspath[0:abspath.find('WebKitTools') - 1]

Seems like I could construct cases where this would break, but this seems good enough and concise.
Comment 4 Mihai Parparita 2010-11-30 11:26:20 PST
Comment on attachment 75094 [details]
Patch

Commit queue is pretty backed up, will land this manually.
Comment 5 Mihai Parparita 2010-11-30 11:27:53 PST
Committed r72940: <http://trac.webkit.org/changeset/72940>