Bug 50186

Summary: Switch web audio code to use FloatPoint3D instead of Vector3
Product: WebKit Reporter: Chris Rogers <crogers>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, kbr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch kbr: review+

Chris Rogers
Reported 2010-11-29 14:29:19 PST
Switch web audio code to use FloatPoint3D instead of Vector3
Attachments
Patch (14.31 KB, patch)
2010-11-29 14:34 PST, Chris Rogers 		no flags
DetailsFormatted DiffDiff
Patch (19.12 KB, patch)
2010-11-29 16:13 PST, Chris Rogers 		kbr: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Rogers
Comment 1 2010-11-29 14:34:15 PST
Created attachment 75063 [details] Patch
Kenneth Russell
Comment 2 2010-11-29 14:54:26 PST
Comment on attachment 75063 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=75063&action=review Are these the last uses of Vector3? If so, I think we should remove those files as well. Or is that planned in a separate patch? > WebCore/platform/graphics/FloatPoint3D.h:178 > +inline double distance(const FloatPoint3D& a, const FloatPoint3D& b) I'm not sure that adding this function to the global WebCore namespace is a good idea. Could it be expressed as a method "double distanceTo(const FloatPoint3D& other) const"?
Chris Rogers
Comment 3 2010-11-29 16:13:14 PST
Created attachment 75077 [details] Patch
Chris Rogers
Comment 4 2010-11-29 16:15:21 PST
> Are these the last uses of Vector3? If so, I think we should remove those files as well. Or is that planned in a separate patch? Yes, the new patch also removes wtf/Vector3.h >> WebCore/platform/graphics/FloatPoint3D.h:178 >> +inline double distance(const FloatPoint3D& a, const FloatPoint3D& b) > I'm not sure that adding this function to the global WebCore namespace is a good idea. Could it be expressed as a method "double distanceTo(const FloatPoint3D& other) const"? Yes, I've changed this method to distanceTo() as you propose.
Kenneth Russell
Comment 5 2010-11-29 17:04:22 PST
Comment on attachment 75077 [details] Patch Looks good to me.
Chris Rogers
Comment 6 2010-11-29 17:19:01 PST
Committed r72853: <http://trac.webkit.org/changeset/72853>
WebKit Review Bot
Comment 7 2010-11-29 18:03:38 PST
http://trac.webkit.org/changeset/72853 might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: fast/profiler/throw-exception-from-eval.html
Note You need to log in before you can comment on or make changes to this bug.