Bug 50185 – Should be able to pause and resume downloads

• Component: WebKit2
• Status: RESOLVED FIXED

[Anders Carlsson]

Should be able to pause and resume downloads

[Anders Carlsson]

<rdar://problem/8691135>

[Anders Carlsson]

Created attachment 75062 [details]
Patch

[Darin Adler]

Comment on attachment 75062 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=75062&action=review

Might be better to name this resumptionData rather than resumeData so it doesn’t sound like a verb phrase. But I guess the NSURLDownload method is already named resumeData?

> WebKit2/UIProcess/Downloads/DownloadProxy.cpp:153
> +    if (!resumeData.isEmpty())
> +        m_resumeData = WebData::create(resumeData.data(), resumeData.size());

Would be nice to share this code instead of writing it twice.

[Anders Carlsson]

(In reply to comment #3)
> (From update of attachment 75062 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=75062&action=review
> 
> Might be better to name this resumptionData rather than resumeData so it doesn’t sound like a verb phrase. But I guess the NSURLDownload method is already named resumeData?

Yeah.

> 
> > WebKit2/UIProcess/Downloads/DownloadProxy.cpp:153
> > +    if (!resumeData.isEmpty())
> > +        m_resumeData = WebData::create(resumeData.data(), resumeData.size());
> 
> Would be nice to share this code instead of writing it twice.

Fixed.

Thanks for reviewing!

[Anders Carlsson]

Committed r72841: <http://trac.webkit.org/changeset/72841>