Bug 50175

Summary: layer()->currentTransform() is stale when layout changes the box size
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, bdakin, eric, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.5   
Attachments:
Description Flags
Patch hyatt: review+

Simon Fraser (smfr)
Reported 2010-11-29 13:18:08 PST
layer()->currentTransform() can get stale; it's initially computed from RenderLayer::styleChanged, but the box size may be 0x0 at that point. When layout happens, the box-size can change, so the transform-origin (which depends on box size) changes, and the transform needs to be updated.
Attachments
Patch (10.74 KB, patch)
2010-11-29 15:06 PST, Simon Fraser (smfr) 		hyatt: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2010-11-29 13:19:59 PST
Note: once this is fixed, we should be able to remove the updateTransform() in RenderBox::applyLayerTransformToRect().
Simon Fraser (smfr)
Comment 2 2010-11-29 15:06:57 PST
Created attachment 75069 [details] Patch
Dave Hyatt
Comment 3 2010-11-29 15:09:36 PST
Comment on attachment 75069 [details] Patch r=me
Simon Fraser (smfr)
Comment 4 2010-11-29 15:14:28 PST
http://trac.webkit.org/changeset/72839
WebKit Review Bot
Comment 5 2010-11-29 15:43:15 PST
http://trac.webkit.org/changeset/72839 might have broken Qt Linux Release The following tests are not passing: fast/overflow/overflow-update-transform.html
Simon Fraser (smfr)
Comment 6 2010-11-29 16:37:58 PST
Reopening to fix some issues only seen in pixel tests.
Simon Fraser (smfr)
Comment 7 2010-11-29 16:39:38 PST
Ah, bug 50188 was filed to cover the failures.
Note You need to log in before you can comment on or make changes to this bug.